You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "tswstarplanet (GitHub)" <gi...@apache.org> on 2019/03/21 21:03:17 UTC
[GitHub] [incubator-dubbo] tswstarplanet opened pull request #3714:
Merge dubbo-serialization-gson into incubator-dubbo
## What is the purpose of the change
Merge dubbo-serialization-gson project to dubbo
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3714 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] tswstarplanet commented on issue #3714:
[Dubbo-3708]Merge dubbo-serialization-gson into incubator-dubbo
Posted by "tswstarplanet (GitHub)" <gi...@apache.org>.
I have run the unit test, and write a demo to test the new module
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3714 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on pull request #3714:
[Dubbo-3707] Merge dubbo-serialization-gson into incubator-dubbo
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
It is unnecessary to add the dependency here.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3714 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on issue #3714:
[Dubbo-3707] Merge dubbo-serialization-gson into incubator-dubbo
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
Sorry, there is some conflict, I think it is due to the avro serialization has been merged. Could you please resolve the conflict?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3714 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] tswstarplanet commented on pull request
#3714: [Dubbo-3707] Merge dubbo-serialization-gson into incubator-dubbo
Posted by "tswstarplanet (GitHub)" <gi...@apache.org>.
OK, I will do it tonight !
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3714 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] CrazyHZM commented on pull request #3714:
[Dubbo-3707] Merge dubbo-serialization-gson into incubator-dubbo
Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
Hi, since 2.7.1 has been released, could you update it to 2.7.2-SNAPSHOT?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3714 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on pull request #3714:
[Dubbo-3707] Merge dubbo-serialization-gson into incubator-dubbo
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
What is the dependencies of gson? Are all the licenses compatible with Apache?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3714 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3714:
[Dubbo-3707]Merge dubbo-serialization-gson into incubator-dubbo
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3714?src=pr&el=h1) Report
> Merging [#3714](https://codecov.io/gh/apache/incubator-dubbo/pull/3714?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/6e4ff91dfca4395a8d1b180f40f632e97acf779d?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `92.3%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3714?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3714 +/- ##
============================================
+ Coverage 63.55% 63.65% +0.09%
Complexity 71 71
============================================
Files 703 706 +3
Lines 31001 31066 +65
Branches 5022 5023 +1
============================================
+ Hits 19702 19774 +72
+ Misses 9027 9019 -8
- Partials 2272 2273 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3714?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dubbo/common/serialize/gson/GsonSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3714/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWdzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvZ3Nvbi9Hc29uU2VyaWFsaXphdGlvbi5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...bo/common/serialize/gson/GsonJsonObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3714/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWdzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvZ3Nvbi9Hc29uSnNvbk9iamVjdE91dHB1dC5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...bbo/common/serialize/gson/GsonJsonObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3714/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWdzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvZ3Nvbi9Hc29uSnNvbk9iamVjdElucHV0LmphdmE=) | `80% <80%> (ø)` | `0 <0> (?)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3714/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `57.64% <0%> (-4.71%)` | `0% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3714/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `67.21% <0%> (-3.28%)` | `0% <0%> (ø)` | |
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3714/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `65.88% <0%> (+1.17%)` | `0% <0%> (ø)` | :arrow_down: |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3714/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `75.51% <0%> (+2.04%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3714/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3714?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3714?src=pr&el=footer). Last update [6e4ff91...348f22b](https://codecov.io/gh/apache/incubator-dubbo/pull/3714?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3714 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org