You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/08/08 00:13:43 UTC
[GitHub] [helix] dasahcc commented on a change in pull request #378: Make
the reservoir used in ZkClientPathMonitor metric configurable.
dasahcc commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable.
URL: https://github.com/apache/helix/pull/378#discussion_r311811595
##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ZkClientMonitor.java
##########
@@ -63,6 +67,11 @@
public ZkClientMonitor(String monitorType, String monitorKey, String monitorInstanceName,
boolean monitorRootOnly, ZkEventThread zkEventThread) {
+ this(monitorType, monitorKey, monitorInstanceName, monitorRootOnly, zkEventThread, null);
+ }
+
+ public ZkClientMonitor(String monitorType, String monitorKey, String monitorInstanceName,
+ boolean monitorRootOnly, ZkEventThread zkEventThread, final Reservoir mbeanReservoir) {
Review comment:
Is the final needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org