[GitHub] [hbase] infraio commented on a change in pull request #2337: HBASE-24973 Remove read point parameter in StoreFlush#performFlush

[GitBox <gi...@apache.org>]

infraio commented on a change in pull request #2337:
URL: https://github.com/apache/hbase/pull/2337#discussion_r481147556



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlusher.java
##########
@@ -73,20 +73,20 @@ protected void finalizeWriter(StoreFileWriter writer, long cacheFlushSeqNum,
   /**
    * Creates the scanner for flushing snapshot. Also calls coprocessors.
    * @param snapshotScanners
-   * @param smallestReadPoint
    * @return The scanner; null if coprocessor is canceling the flush.
    */
   protected final InternalScanner createScanner(List<KeyValueScanner> snapshotScanners,
-      long smallestReadPoint, FlushLifeCycleTracker tracker) throws IOException {

Review comment:
       This remove the smallestReadPoint parameter from createScanner method, too? Change the issue title to talk about this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org