You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/23 16:34:21 UTC
[GitHub] [airflow] potiuk opened a new pull request #17194: Only allows supported field types to be used in custom connections
potiuk opened a new pull request #17194:
URL: https://github.com/apache/airflow/pull/17194
Only four field types are supported in Connection Forms:
String, Password, Integer, Boolean.
Previously when custom connections tried to use other field
type, ConnectionForm behaved in a very strange way - the
connection form reloaded quickly hiding the actual error
and no error was printed making it next to impossible to figure
out the root cause of the problem.
With this change, non-supported field types generate Warning
and the Connections that use them are not added to the list of
supported connections.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #17194: Only allows supported field types to be used in custom connections
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #17194:
URL: https://github.com/apache/airflow/pull/17194#issuecomment-885760389
cc: @soltanianalytics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #17194: Only allows supported field types to be used in custom connections
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #17194:
URL: https://github.com/apache/airflow/pull/17194#issuecomment-885795490
Now. When someone asks me "why do you test EVERYTHING" I can point them to that error of mine 🤦 @kaxil - see the fixup ! I bet no'one would have spotted it while review.
https://github.com/apache/airflow/pull/17194/commits/84bd41b44760481e7c69147046a5bb3afcbf71ca
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #17194: Only allows supported field types to be used in custom connections
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #17194:
URL: https://github.com/apache/airflow/pull/17194#issuecomment-885785320
tests are faining
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17194: Only allows supported field types to be used in custom connections
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17194:
URL: https://github.com/apache/airflow/pull/17194#issuecomment-885760788
Here is what happens when you try to load "Ewah" connections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17194: Only allows supported field types to be used in custom connections
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17194:
URL: https://github.com/apache/airflow/pull/17194#issuecomment-885795490
Now. When someone asks me "why do you test EVERYTHING" I can point them to that error of mine 🤦 @kaxil - see the fixup ! I bet no'one would have spotted it while review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17194: Only allows supported field types to be used in custom connections
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17194:
URL: https://github.com/apache/airflow/pull/17194#issuecomment-885785488
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17194: Only allows supported field types to be used in custom connections
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17194:
URL: https://github.com/apache/airflow/pull/17194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17194: Only allows supported field types to be used in custom connections
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17194:
URL: https://github.com/apache/airflow/pull/17194#issuecomment-885789654
😱 ERROR: Number of hooks registered is wrong: 59 😱 - did I just uncover a wrong field somewhere :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17194: Only allows supported field types to be used in custom connections
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17194:
URL: https://github.com/apache/airflow/pull/17194#issuecomment-885760389
cc: soltanianalytics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #17194: Only allows supported field types to be used in custom connections
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #17194:
URL: https://github.com/apache/airflow/pull/17194#issuecomment-885785320
tests are failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org