You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2024/03/13 18:13:57 UTC
[PR] [Disco] Propagate structlog/logging config to workers [tvm]
Lunderberg opened a new pull request, #16715:
URL: https://github.com/apache/tvm/pull/16715
This is a follow-up to #16618, which propagates the `structlog` configuration to disco worker processes. For configurations that use `structlog.stdlib` to integrate `structlog` with the stdlib `logging` module, this integration must also be forwarded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Disco] Propagate structlog/logging config to workers [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #16715:
URL: https://github.com/apache/tvm/pull/16715#issuecomment-2020421377
> This seems straightforward enough, though I'm not aware of the wider context.
Thank you. For context, some applications use `structlog` to provide more flexible logging than python's stdlib `logging`. The `structlog` configuration determines what pre-processing is done for the log statements (e.g. appending contextual information to a log statement). When starting child processes using `multiprocessing`, it would be useful for the child processes to format/save their logs in the same manner as the parent, but this doesn't occur by default. In [PR#16618](https://github.com/apache/tvm/pull/16618), I added handling to forward the `structlog` configuration from the main process to the `tvm.runtime.disco` worker processes.
However, some configurations ([example from `structlog`'s documentation](https://www.structlog.org/en/stable/standard-library.html#rendering-using-structlog-based-formatters-within-logging) integrate `structlog` with the stdlib `logging`. The previous implementation only forwarded the configuration held by `structlog`, and didn't forward the configuration within the stdlib `logging`. This PR closes that gap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Disco] Propagate structlog/logging config to workers [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg merged PR #16715:
URL: https://github.com/apache/tvm/pull/16715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org