You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "kevin-cao (via GitHub)" <gi...@apache.org> on 2023/05/04 02:46:04 UTC

[GitHub] [dubbo] kevin-cao opened a new issue, #12227: [metrics]在Dubbo3.2的provider里该如何收集业务自定义指标

kevin-cao opened a new issue, #12227:
URL: https://github.com/apache/dubbo/issues/12227

   **Environment**
   
   - Dubbo version: 3.2.0
   - SpringBoot version: 2.7.11
   - Prometheus version: 2.37.7
   - JDK version: 8
   
   Provider已接入dubbo-metrics，现需要通过micrometer api上报业务相关的自定义指标到Prometheus。由于provider中没有暴露用于业务指标的HTTPServer Endpoint，无法直接使用io.micrometer.core.instrument.Metrics。如何暴露业务指标的Endpoint，目前想到两种办法：
   1. 复用Dubbo自身框架指标的Endpoin，也就是QOS http server
   2. 创建一个新的业务指标HTTPSever对象，暴露新端口
   
   比较倾向1(避免创建httpserver)。不过1的话该如何复用qos端口，自定义指标直接上报到/metrics路径？还是扩展BaseCommand使用新路径上报？官方有没有推荐做法或这方面的支持？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] wxbty commented on issue #12227: [metrics]在Dubbo3.2的provider里该如何收集业务自定义指标

Posted by "wxbty (via GitHub)" <gi...@apache.org>.
wxbty commented on issue #12227:
URL: https://github.com/apache/dubbo/issues/12227#issuecomment-1534715939

   使用自带org.apache.dubbo.metrics.collector.MetricsCollector的spi，可以加载第三方收集器，参考RegistryMetricsCollector实现


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] songxiaosheng commented on issue #12227: [metrics]在Dubbo3.2的provider里该如何暴露业务自定义指标

Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on issue #12227:
URL: https://github.com/apache/dubbo/issues/12227#issuecomment-1538129136

   ![e0728ad358dc4af983cd1f954cf1d8f2.png](https://user-images.githubusercontent.com/81170548/236799277-30e6e3df-b932-4ef0-adbb-1f8185d5aa89.png)
   
   这个版本你先用这个方法，后面我们文档出一下如何让用户使用的文档


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kevin-cao closed issue #12227: [metrics]在Dubbo3.2的provider里该如何暴露业务自定义指标

Posted by "kevin-cao (via GitHub)" <gi...@apache.org>.
kevin-cao closed issue #12227: [metrics]在Dubbo3.2的provider里该如何暴露业务自定义指标
URL: https://github.com/apache/dubbo/issues/12227


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] songxiaosheng commented on issue #12227: [metrics]在Dubbo3.2的provider里该如何收集业务自定义指标

Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on issue #12227:
URL: https://github.com/apache/dubbo/issues/12227#issuecomment-1536951450

   @kevin-cao 需要dubbo提供micrometer的注册表么还是提供一套指标采集标准


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kevin-cao commented on issue #12227: [metrics]在Dubbo3.2的provider里该如何收集业务自定义指标

Posted by "kevin-cao (via GitHub)" <gi...@apache.org>.
kevin-cao commented on issue #12227:
URL: https://github.com/apache/dubbo/issues/12227#issuecomment-1537106193

   > @kevin-cao 需要dubbo提供micrometer的注册表么还是提供一套指标采集标准
   
   @songxiaosheng 需要dubbo提供micrometer的注册表，可以直接调用MeterRegistry.counter()、MeterRegistry.gauge()等方法，并且能够让prometheus通过qos端口抓取到


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] songxiaosheng commented on issue #12227: [metrics]在Dubbo3.2的provider里该如何收集业务自定义指标

Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on issue #12227:
URL: https://github.com/apache/dubbo/issues/12227#issuecomment-1537125886

   > > @kevin-cao 需要dubbo提供micrometer的注册表么还是提供一套指标采集标准
   > 
   > @songxiaosheng 需要dubbo提供micrometer的注册表，可以直接调用MeterRegistry.counter()、MeterRegistry.gauge()等方法，并且能够让prometheus通过qos端口抓取到
   
   最近看下提供给你


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kevin-cao commented on issue #12227: [metrics]在Dubbo3.2的provider里该如何暴露业务自定义指标

Posted by "kevin-cao (via GitHub)" <gi...@apache.org>.
kevin-cao commented on issue #12227:
URL: https://github.com/apache/dubbo/issues/12227#issuecomment-1539283321

   好的👍 试了下可以了


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org