[GitHub] TinyAllen commented on a change in pull request #223: Optimization: Local span layer issue

[GitBox <gi...@apache.org>]

TinyAllen commented on a change in pull request #223: Optimization: Local span layer issue
URL: https://github.com/apache/incubator-skywalking-ui/pull/223#discussion_r250483435
 
 

 ##########
 File path: src/components/TraceTree/d3-trace.js
 ##########
 @@ -222,7 +222,12 @@ export default class TraceMap {
       .attr('text-anchor', 'start')
       .attr('fill', d => this.type[d.data.layer])
       .attr('stroke', d => this.type[d.data.layer])
-      .text(d => d.data.layer);
+      .text(d => {
+        if(d.data.type == 'Local' && d.data.layer == 'Unknown'){
 
 Review comment:
   I think only checking the ''Unkown" is enough, using ternary statement to do this well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services