[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #629: GEODE-8364: Change log level at runtime

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #629:
URL: https://github.com/apache/geode-native/pull/629#discussion_r456530395



##########
File path: cppcache/include/geode/Cache.hpp
##########
@@ -239,6 +241,10 @@ class APACHE_GEODE_EXPORT Cache : public GeodeCache {
 
   SystemProperties& getSystemProperties() const override;
 
+  void setLogLevel(LogLevel newLevel);

Review comment:
       Please add documentation to these new methods.

##########
File path: cppcache/test/CacheTest.cpp
##########
@@ -61,3 +62,10 @@ TEST(CacheTest, close) {
   EXPECT_THROW(cache.readyForEvents(), CacheClosedException);
   EXPECT_THROW(cache.rootRegions(), CacheClosedException);
 }
+
+TEST(CacheTest, changeLogLevel) {
+  auto cache = CacheFactory{}.set("log-level", "info").create();
+  ASSERT_EQ(cache.getLogLevel(), LogLevel::Info);

Review comment:
       What happens if you call `cache.getSystemProperties.getLogLevel()` after changing it via `Cache`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org