[I] Preserve config source isolation in GuiConfigService instead of merging all endpoints into one flat map [texera]

["Ma77Ball (via GitHub)" <gi...@apache.org>]

Ma77Ball opened a new issue, #5669:
URL: https://github.com/apache/texera/issues/5669

   ## Task Summary
   
   Follow-up from PR #5545 ([review comment](https://github.com/apache/texera/pull/5545#discussion_r3393706149)).
   
   `GuiConfigService.loadPostLogin()` fetches `/config/gui`, `/config/amber`, and `/config/user-system` and spreads them all into a single flat `this.config` map. This loses the information about which source each key came from.
   
   Yicong's review:
   > this design is horrible. it merges configs from different sources into one map, essentially loses the isolated information. I think in a future PR we should at least make them reserve the source of the config. e.g.,
   > `this.config['amber'] = amberConfig`
   
   ### Scope
   - Restructure `GuiConfigService` so config from each endpoint stays namespaced by its source (e.g. `config.amber`, `config.gui`, `config.userSystem`) rather than flattened together.
   - Update consumers that read these config values accordingly.
   - Update `gui-config.service.spec.ts`.
   
   ### Task Type
   Refactor / Cleanup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Preserve config source isolation in GuiConfigService instead of merging all endpoints into one flat map [texera]

["aicam (via GitHub)" <gi...@apache.org>]

aicam closed issue #5669: Preserve config source isolation in GuiConfigService instead of merging all endpoints into one flat map
URL: https://github.com/apache/texera/issues/5669


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Preserve config source isolation in GuiConfigService instead of merging all endpoints into one flat map [texera]

["Ma77Ball (via GitHub)" <gi...@apache.org>]

Ma77Ball commented on issue #5669:
URL: https://github.com/apache/texera/issues/5669#issuecomment-4697134066

   /take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Preserve config source isolation in GuiConfigService instead of merging all endpoints into one flat map [texera]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on issue #5669:
URL: https://github.com/apache/texera/issues/5669#issuecomment-4697077039

   <!-- texera:template-compliance -->
   👋 Thanks for opening this issue, @Ma77Ball!
   
   It looks like the issue description doesn't quite follow our template yet:
   
   - This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
   
   Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
   
   You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org