[GitHub] [dubbo-go-pixiu] PhilYue commented on a diff in pull request #469: WASM Plugin for Pixiu

[GitBox <gi...@apache.org>]

PhilYue commented on code in PR #469:
URL: https://github.com/apache/dubbo-go-pixiu/pull/469#discussion_r956711027


##########
pkg/filter/http/proxywasm/filter.go:
##########
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package proxywasm
+
+import (
+	"github.com/apache/dubbo-go-pixiu/pkg/common/constant"
+	"github.com/apache/dubbo-go-pixiu/pkg/common/extension/filter"
+	"github.com/apache/dubbo-go-pixiu/pkg/context/http"
+	"github.com/apache/dubbo-go-pixiu/pkg/logger"
+	"github.com/apache/dubbo-go-pixiu/pkg/wasm"
+)
+
+func init() {
+	filter.RegisterHttpFilter(&Plugin{})
+}
+
+type (
+	Plugin struct {
+	}
+
+	WasmFilterFactory struct {
+		cfg *Config
+	}
+
+	WasmFilter struct {
+		abiContextWrappers map[string]*wasm.ABIContextWrapper
+	}
+
+	Config struct {
+		WasmServices []*Service `yaml:"wasm_services" json:"wasm_services" mapstructure:"wasm_services"`
+	}
+
+	Service struct {
+		Name string `yaml:"name" json:"name" mapstructure:"name"`
+	}
+)
+
+func (w *WasmFilter) Decode(ctx *http.HttpContext) filter.FilterStatus {
+
+	// sample: display http header
+	if wrapper := w.abiContextWrappers[wasm.HeaderLevel]; wrapper != nil {
+		wrapper.Context.Instance.Lock(wrapper.Context)
+		defer wrapper.Context.Instance.Unlock()
+
+		err := wrapper.Context.GetExports().ProxyOnContextCreate(wrapper.ContextID, wasm.GetServiceRootID(wasm.HeaderLevel))
+		if err != nil {
+			logger.Warnf("[dubbo-go-pixiu] wasmFilter call ProxyOnContextCreate failed: %v", err)
+			return filter.Continue
+		}
+
+		_, err = wrapper.Context.GetExports().ProxyOnRequestHeaders(wrapper.ContextID, int32(len(ctx.Request.Header)), 1)
+		if err != nil {
+			logger.Warnf("[dubbo-go-pixiu] wasmFilter call ProxyOnRequestHeaders failed: %v", err)
+		}
+
+		err = wrapper.Context.GetExports().ProxyOnDelete(wrapper.ContextID)
+		if err != nil {
+			logger.Warnf("[dubbo-go-pixiu] wasmFilter call ProxyOnDelete failed: %v", err)
+		}
+	}
+	return filter.Continue
+}
+
+func (w *WasmFilter) Encode(ctx *http.HttpContext) filter.FilterStatus {
+	for _, wrapper := range w.abiContextWrappers {
+		if err := wasm.ContextDone(wrapper); err != nil {
+			logger.Warnf("[dubbo-go-pixiu] wasmFilter call contextDone failed: %v", err)
+		}
+	}
+
+	if val := ctx.GetHeader("go-wasm-header"); val != "" {
+		if _, err := ctx.Writer.Write([]byte(val)); err != nil {
+			logger.Errorf("write response error: %s", err)
+		}
+	}
+	return filter.Continue
+}
+
+func (factory *WasmFilterFactory) Config() interface{} {
+	return factory.cfg
+}
+
+func (factory *WasmFilterFactory) Apply() error {
+	return nil
+}
+
+func (factory *WasmFilterFactory) PrepareFilterChain(ctx *http.HttpContext, chain filter.FilterChain) error {
+	filter := &WasmFilter{
+		abiContextWrappers: make(map[string]*wasm.ABIContextWrapper),
+	}
+	for _, service := range factory.cfg.WasmServices {
+		if abiContext := wasm.CreateABIContextByName(service.Name, ctx); abiContext != nil {
+			filter.abiContextWrappers[service.Name] = abiContext

Review Comment:
   此处 abiContext 的key `service.Name` 是不是必须要与文件`key.go` 的 `HeaderLevel` 匹配



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org