You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "igreenfield (via GitHub)" <gi...@apache.org> on 2023/11/28 11:15:07 UTC
[PR] [SPARK-46137] update janino to version 3.1.11 [spark]
igreenfield opened a new pull request, #44053:
URL: https://github.com/apache/spark/pull/44053
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Update janino to version 3.1.11
### Why are the changes needed?
it fixes compilation error in some cases.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Run current tests
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46137] update janino to version 3.1.11 [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #44053:
URL: https://github.com/apache/spark/pull/44053#issuecomment-1833560594
> it fixes compilation error in some cases.
I have seen this issue related to Spark: https://github.com/janino-compiler/janino/issues/208, and I think that if the upgrade is really need, a reproducible test case should also be added to ensure that this issue does not occur again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46137] update janino to version 3.1.11 [spark]
Posted by "igreenfield (via GitHub)" <gi...@apache.org>.
igreenfield commented on PR #44053:
URL: https://github.com/apache/spark/pull/44053#issuecomment-1831379592
Hi @dongjoon-hyun,
1. About the case you can look at the jira case.
2. I will look at the other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46137] update janino to version 3.1.11 [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #44053:
URL: https://github.com/apache/spark/pull/44053#issuecomment-1833591583
> @LuciferYang this is the issue I created for Janino.
I know, but if the main reason for `Why are the changes needed` is to address an issue encountered in Apache Spark that requires upgrading janino, then it would be best to add test cases in Spark to demonstrate this and serve as continuous regression testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46137] update janino to version 3.1.11 [spark]
Posted by "igreenfield (via GitHub)" <gi...@apache.org>.
igreenfield closed pull request #44053: [SPARK-46137] update janino to version 3.1.11
URL: https://github.com/apache/spark/pull/44053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46137] update janino to version 3.1.11 [spark]
Posted by "igreenfield (via GitHub)" <gi...@apache.org>.
igreenfield commented on PR #44053:
URL: https://github.com/apache/spark/pull/44053#issuecomment-1832046214
@LuciferYang What part of performance results of tpcds is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46137] update janino to version 3.1.11 [spark]
Posted by "igreenfield (via GitHub)" <gi...@apache.org>.
igreenfield commented on PR #44053:
URL: https://github.com/apache/spark/pull/44053#issuecomment-1833565403
@LuciferYang this is the issue I created for Janino.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46137] update janino to version 3.1.11 [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #44053:
URL: https://github.com/apache/spark/pull/44053#issuecomment-1833572687
> @LuciferYang What part of performance results of tpcds is needed?
for example, running a full tpcds test using GitHub Action, comparing the data changes with and without this pr, and testing with the same Cpu model are required. This may require multiple tests to try our luck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46137] update janino to version 3.1.11 [spark]
Posted by "igreenfield (via GitHub)" <gi...@apache.org>.
igreenfield commented on PR #44053:
URL: https://github.com/apache/spark/pull/44053#issuecomment-1838869496
@LuciferYang I ran the benchmark action 3 times on master and it never finished... how I can do compare if even the master can't finish it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org