You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/10/16 22:30:34 UTC

[GitHub] [cordova-plugin-inappbrowser] mosababubakr edited a comment on issue #546: Add top notch detection

mosababubakr edited a comment on issue #546: Add top notch detection
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/546#issuecomment-542917308
 
 
   Hello guys,
   
   You can take SAFARI browser as an example, 
   If you try to show safari in landscape mode, you will see that the status bar is hidden in landscape mode. (Iphone x family)
   
   So, i think that inappbrowser could be better, if it appear as safari browser for ios devices layout.
   
   And also, safari browser set safe margins by default in both portrait and landscape modes, thus,  inappbrowser should be in same strategy, because we can’t control other external website links that opened in inappbrowser.
   (We cannot control the css of the layout for the external links).
   
   So, please take a look by trying to open any url for example: youtube.com in safari browser for both landscape and portrait, and you will notice the default safe margin (in the edge of the screen, both left and right sides), which was set by apple developers for safari browser app.
   
   Hope this help.
   
   Regards

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org