[GitHub] [incubator-pegasus] hycdong commented on a diff in pull request #1146: feat(backup): 8. meta handle backup_response during uploading and succeed

[GitBox <gi...@apache.org>]

hycdong commented on code in PR #1146:
URL: https://github.com/apache/incubator-pegasus/pull/1146#discussion_r965427601


##########
src/rdsn/src/meta/meta_backup_engine.cpp:
##########
@@ -246,7 +246,31 @@ void meta_backup_engine::on_backup_reply(const error_code err,
         }
     }
 
-    // TODO(heyuchen): handle other status
+    if (response.status == backup_status::UPLOADING) {

Review Comment:
   The related logic of `on_backup_reply` function is like:
   ```
   if(response.status == backup_status::CHECKPOINTED){
     // do something
   }
   
   if(response.status == backup_status::UPLOADING){
     // do something
   }
   
   if(response.status == backup_status::SUCCEED){
     // do something
     return;
   }
   
   // status: CHECKPOINTING, CHECKPOINTED, UPLOADING
   print_log
   retry_backup
   ```
   
   The purpose that I don't use `if...else` is to print log and call retry_backup function, you can see the whole `on_backup_reply` function.
   
   



##########
src/rdsn/src/meta/meta_backup_engine.cpp:
##########
@@ -246,7 +246,31 @@ void meta_backup_engine::on_backup_reply(const error_code err,
         }
     }
 
-    // TODO(heyuchen): handle other status
+    if (response.status == backup_status::UPLOADING) {
+        ddebug_f(
+            "backup_id({}): backup for partition {} from server {} is uploading, progress = {}",
+            _cur_backup.backup_id,
+            pid.to_string(),
+            primary.to_string(),
+            response.upload_progress);
+    }
+
+    if (response.status == backup_status::SUCCEED) {

Review Comment:
   Same



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org