You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "bsh786 (via GitHub)" <gi...@apache.org> on 2023/04/01 22:31:55 UTC

[GitHub] [eventmesh] bsh786 opened a new pull request, #3600: [ISSUE #3484] Did code optimization in PulsarClientWrapper. Closes $3484

bsh786 opened a new pull request, #3600:
URL: https://github.com/apache/eventmesh/pull/3600

   
   ### Documentation
   
   - Does this pull request introduce a new feature? (yes / no) No
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   - If a feature is not applicable for documentation, explain why?
   - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [eventmesh] codecov[bot] commented on pull request #3600: [ISSUE #3484] Did code optimization in PulsarClientWrapper. Closes #3484

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3600:
URL: https://github.com/apache/eventmesh/pull/3600#issuecomment-1493209457

   ## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3600?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3600](https://codecov.io/gh/apache/eventmesh/pull/3600?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e8ab441) into [master](https://codecov.io/gh/apache/eventmesh/commit/228cc82a041d8de747efc2a398f6a0d78799728b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (228cc82) will **decrease** coverage by `0.87%`.
   > The diff coverage is `7.69%`.
   
   > :exclamation: Current head e8ab441 differs from pull request most recent head 6922664. Consider uploading reports for the commit 6922664 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3600      +/-   ##
   ============================================
   - Coverage     14.62%   13.76%   -0.87%     
   + Complexity     1526     1291     -235     
   ============================================
     Files           651      571      -80     
     Lines         31713    29239    -2474     
     Branches       3032     2886     -146     
   ============================================
   - Hits           4638     4024     -614     
   + Misses        26659    24841    -1818     
   + Partials        416      374      -42     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/java/org/apache/eventmesh/common/Constants.java](https://codecov.io/gh/apache/eventmesh/pull/3600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9Db25zdGFudHMuamF2YQ==) | `85.71% <ø> (ø)` | |
   | [.../eventmesh/common/enums/EventMeshProtocolType.java](https://codecov.io/gh/apache/eventmesh/pull/3600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9lbnVtcy9FdmVudE1lc2hQcm90b2NvbFR5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ventmesh/common/protocol/tcp/EventMeshMessage.java](https://codecov.io/gh/apache/eventmesh/pull/3600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC90Y3AvRXZlbnRNZXNoTWVzc2FnZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...rotocol/workflow/protos/EventmeshWorkflowGrpc.java](https://codecov.io/gh/apache/eventmesh/pull/3600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC93b3JrZmxvdy9wcm90b3MvRXZlbnRtZXNoV29ya2Zsb3dHcnBjLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../org/apache/eventmesh/common/EventMeshMessage.java](https://codecov.io/gh/apache/eventmesh/pull/3600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9FdmVudE1lc2hNZXNzYWdlLmphdmE=) | `35.29% <100.00%> (+3.71%)` | :arrow_up: |
   
   ... and [240 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3600/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


[GitHub] [eventmesh] mytang0 merged pull request #3600: [ISSUE #3484] Did code optimization in PulsarClientWrapper. Closes #3484

Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 merged PR #3600:
URL: https://github.com/apache/eventmesh/pull/3600


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org