You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by se...@apache.org on 2008/10/05 21:17:11 UTC
svn commit: r701858 - in /directory/studio/trunk:
ldapbrowser-common/src/main/java/org/apache/directory/studio/ldapbrowser/common/actions/
ldapbrowser-common/src/main/java/org/apache/directory/studio/ldapbrowser/common/dialogs/preferences/
ldapbrowser-...
Author: seelmann
Date: Sun Oct 5 12:17:10 2008
New Revision: 701858
URL: http://svn.apache.org/viewvc?rev=701858&view=rev
Log:
Renamed 'show raw values' to 'show decorated values' and inverted logic
Removed:
directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/ldapbrowser/common/actions/ShowRawValuesAction.java
Modified:
directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/ldapbrowser/common/dialogs/preferences/AttributesPreferencePage.java
directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/ldapbrowser/common/widgets/entryeditor/EntryEditorWidgetActionGroup.java
directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/valueeditors/AbstractDialogValueEditor.java
directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/valueeditors/AbstractInPlaceStringValueEditor.java
directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/entry/EntryEditorActionGroup.java
directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/searchresult/SearchResultEditorActionGroup.java
Modified: directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/ldapbrowser/common/dialogs/preferences/AttributesPreferencePage.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/ldapbrowser/common/dialogs/preferences/AttributesPreferencePage.java?rev=701858&r1=701857&r2=701858&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/ldapbrowser/common/dialogs/preferences/AttributesPreferencePage.java (original)
+++ directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/ldapbrowser/common/dialogs/preferences/AttributesPreferencePage.java Sun Oct 5 12:17:10 2008
@@ -44,7 +44,7 @@
public class AttributesPreferencePage extends PreferencePage implements IWorkbenchPreferencePage
{
- private Button showRawValuesButton;
+ private Button showDecoratedValuesButton;
/**
@@ -85,8 +85,8 @@
BaseWidgetUtils.createSpacer( composite, 1 );
BaseWidgetUtils.createSpacer( composite, 1 );
- showRawValuesButton = BaseWidgetUtils.createCheckbox( composite, "Show raw values", 1 );
- showRawValuesButton.setSelection( getPreferenceStore().getBoolean(
+ showDecoratedValuesButton = BaseWidgetUtils.createCheckbox( composite, "Show decorated values", 1 );
+ showDecoratedValuesButton.setSelection( !getPreferenceStore().getBoolean(
BrowserCommonConstants.PREFERENCE_SHOW_RAW_VALUES ) );
applyDialogFont( composite );
@@ -100,7 +100,7 @@
public boolean performOk()
{
getPreferenceStore().setValue( BrowserCommonConstants.PREFERENCE_SHOW_RAW_VALUES,
- showRawValuesButton.getSelection() );
+ !showDecoratedValuesButton.getSelection() );
return true;
}
@@ -110,7 +110,7 @@
*/
protected void performDefaults()
{
- showRawValuesButton.setSelection( getPreferenceStore().getDefaultBoolean(
+ showDecoratedValuesButton.setSelection( !getPreferenceStore().getDefaultBoolean(
BrowserCommonConstants.PREFERENCE_SHOW_RAW_VALUES ) );
super.performDefaults();
}
Modified: directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/ldapbrowser/common/widgets/entryeditor/EntryEditorWidgetActionGroup.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/ldapbrowser/common/widgets/entryeditor/EntryEditorWidgetActionGroup.java?rev=701858&r1=701857&r2=701858&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/ldapbrowser/common/widgets/entryeditor/EntryEditorWidgetActionGroup.java (original)
+++ directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/ldapbrowser/common/widgets/entryeditor/EntryEditorWidgetActionGroup.java Sun Oct 5 12:17:10 2008
@@ -32,7 +32,7 @@
import org.apache.directory.studio.ldapbrowser.common.actions.PasteAction;
import org.apache.directory.studio.ldapbrowser.common.actions.PropertiesAction;
import org.apache.directory.studio.ldapbrowser.common.actions.SelectAllAction;
-import org.apache.directory.studio.ldapbrowser.common.actions.ShowRawValuesAction;
+import org.apache.directory.studio.ldapbrowser.common.actions.ShowDecoratedValuesAction;
import org.apache.directory.studio.ldapbrowser.common.actions.ValueEditorPreferencesAction;
import org.apache.directory.studio.ldapbrowser.common.actions.proxy.ActionHandlerManager;
import org.apache.directory.studio.ldapbrowser.common.actions.proxy.BrowserActionProxy;
@@ -64,8 +64,8 @@
/** The open sort dialog action. */
protected OpenSortDialogAction openSortDialogAction;
- /** The show raw values action. */
- protected ShowRawValuesAction showRawValuesAction;
+ /** The show decorated values action. */
+ protected ShowDecoratedValuesAction showDecoratedValuesAction;
/** The show quick filter action. */
protected ShowQuickFilterAction showQuickFilterAction;
@@ -124,7 +124,7 @@
TreeViewer viewer = mainWidget.getViewer();
openSortDialogAction = new OpenSortDialogAction( configuration.getPreferences() );
- showRawValuesAction = new ShowRawValuesAction();
+ showDecoratedValuesAction = new ShowDecoratedValuesAction();
showQuickFilterAction = new ShowQuickFilterAction( mainWidget.getQuickFilterWidget() );
openBestValueEditorActionProxy = new EntryEditorActionProxy( viewer, new OpenBestEditorAction( viewer,
@@ -162,7 +162,7 @@
openSortDialogAction = null;
showQuickFilterAction.dispose();
showQuickFilterAction = null;
- showRawValuesAction = null;
+ showDecoratedValuesAction = null;
openDefaultValueEditorActionProxy.dispose();
openDefaultValueEditorActionProxy = null;
@@ -223,13 +223,13 @@
public void fillMenu( IMenuManager menuManager )
{
menuManager.add( openSortDialogAction );
- menuManager.add( showRawValuesAction );
+ menuManager.add( showDecoratedValuesAction );
menuManager.addMenuListener( new IMenuListener()
{
public void menuAboutToShow( IMenuManager manager )
{
- showRawValuesAction.setChecked( BrowserCommonActivator.getDefault().getPreferenceStore().getBoolean(
- BrowserCommonConstants.PREFERENCE_SHOW_RAW_VALUES ) );
+ showDecoratedValuesAction.setChecked( !BrowserCommonActivator.getDefault().getPreferenceStore()
+ .getBoolean( BrowserCommonConstants.PREFERENCE_SHOW_RAW_VALUES ) );
}
} );
}
Modified: directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/valueeditors/AbstractDialogValueEditor.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/valueeditors/AbstractDialogValueEditor.java?rev=701858&r1=701857&r2=701858&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/valueeditors/AbstractDialogValueEditor.java (original)
+++ directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/valueeditors/AbstractDialogValueEditor.java Sun Oct 5 12:17:10 2008
@@ -73,7 +73,7 @@
/**
* Returns true if the user wishes to show raw values rather than
* user-friendly values. If true the getDisplayValue() methods
- * shouldnot modify the value.
+ * should not modify the value.
*
* @return true if raw values should be displayed
*/
Modified: directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/valueeditors/AbstractInPlaceStringValueEditor.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/valueeditors/AbstractInPlaceStringValueEditor.java?rev=701858&r1=701857&r2=701858&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/valueeditors/AbstractInPlaceStringValueEditor.java (original)
+++ directory/studio/trunk/ldapbrowser-common/src/main/java/org/apache/directory/studio/valueeditors/AbstractInPlaceStringValueEditor.java Sun Oct 5 12:17:10 2008
@@ -66,7 +66,7 @@
/**
* Returns true if the user wishes to show raw values rather than
* user-friendly values. If true the getDisplayValue() methods
- * shouldnot modify the value.
+ * should not modify the value.
*
* @return true if raw values should be displayed
*/
Modified: directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/entry/EntryEditorActionGroup.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/entry/EntryEditorActionGroup.java?rev=701858&r1=701857&r2=701858&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/entry/EntryEditorActionGroup.java (original)
+++ directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/entry/EntryEditorActionGroup.java Sun Oct 5 12:17:10 2008
@@ -280,15 +280,15 @@
menuManager.add( openSortDialogAction );
menuManager.add( new Separator() );
menuManager.add( showOperationalAttributesAction );
- menuManager.add( showRawValuesAction );
+ menuManager.add( showDecoratedValuesAction );
menuManager.add( new Separator() );
menuManager.add( openEntryEditorPreferencePage );
menuManager.addMenuListener( new IMenuListener()
{
public void menuAboutToShow( IMenuManager manager )
{
- showRawValuesAction.setChecked( BrowserCommonActivator.getDefault().getPreferenceStore().getBoolean(
- BrowserCommonConstants.PREFERENCE_SHOW_RAW_VALUES ) );
+ showDecoratedValuesAction.setChecked( !BrowserCommonActivator.getDefault().getPreferenceStore()
+ .getBoolean( BrowserCommonConstants.PREFERENCE_SHOW_RAW_VALUES ) );
showOperationalAttributesAction.setChecked( BrowserCommonActivator.getDefault().getPreferenceStore()
.getBoolean( BrowserCommonConstants.PREFERENCE_ENTRYEDITOR_SHOW_OPERATIONAL_ATTRIBUTES ) );
}
Modified: directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/searchresult/SearchResultEditorActionGroup.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/searchresult/SearchResultEditorActionGroup.java?rev=701858&r1=701857&r2=701858&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/searchresult/SearchResultEditorActionGroup.java (original)
+++ directory/studio/trunk/ldapbrowser-ui/src/main/java/org/apache/directory/studio/ldapbrowser/ui/editors/searchresult/SearchResultEditorActionGroup.java Sun Oct 5 12:17:10 2008
@@ -31,7 +31,7 @@
import org.apache.directory.studio.ldapbrowser.common.actions.NewValueAction;
import org.apache.directory.studio.ldapbrowser.common.actions.PropertiesAction;
import org.apache.directory.studio.ldapbrowser.common.actions.RefreshAction;
-import org.apache.directory.studio.ldapbrowser.common.actions.ShowRawValuesAction;
+import org.apache.directory.studio.ldapbrowser.common.actions.ShowDecoratedValuesAction;
import org.apache.directory.studio.ldapbrowser.common.actions.ValueEditorPreferencesAction;
import org.apache.directory.studio.ldapbrowser.common.actions.proxy.ActionHandlerManager;
import org.apache.directory.studio.ldapbrowser.common.actions.proxy.BrowserActionProxy;
@@ -80,8 +80,8 @@
/** The show links action. */
private ShowLinksAction showLinksAction;
- /** The show raw values action. */
- private ShowRawValuesAction showRawValuesAction;
+ /** The show decorated values action. */
+ private ShowDecoratedValuesAction showDecoratedValuesAction;
/** The open search result editor preference page. */
private OpenSearchResultEditorPreferencePage openSearchResultEditorPreferencePage;
@@ -186,7 +186,7 @@
showDNAction = new ShowDNAction();
showLinksAction = new ShowLinksAction();
- showRawValuesAction = new ShowRawValuesAction();
+ showDecoratedValuesAction = new ShowDecoratedValuesAction();
openSearchResultEditorPreferencePage = new OpenSearchResultEditorPreferencePage();
showQuickFilterAction = new ShowQuickFilterAction( searchResultEditor.getMainWidget().getQuickFilterWidget() );
@@ -278,7 +278,7 @@
{
if ( searchResultEditor != null )
{
- showRawValuesAction = null;
+ showDecoratedValuesAction = null;
showDNAction.dispose();
showDNAction = null;
showLinksAction.dispose();
@@ -347,15 +347,15 @@
{
menuManager.add( showDNAction );
menuManager.add( showLinksAction );
- menuManager.add( showRawValuesAction );
+ menuManager.add( showDecoratedValuesAction );
menuManager.add( new Separator() );
menuManager.add( openSearchResultEditorPreferencePage );
menuManager.addMenuListener( new IMenuListener()
{
public void menuAboutToShow( IMenuManager manager )
{
- showRawValuesAction.setChecked( BrowserCommonActivator.getDefault().getPreferenceStore().getBoolean(
- BrowserCommonConstants.PREFERENCE_SHOW_RAW_VALUES ) );
+ showDecoratedValuesAction.setChecked( !BrowserCommonActivator.getDefault().getPreferenceStore()
+ .getBoolean( BrowserCommonConstants.PREFERENCE_SHOW_RAW_VALUES ) );
}
} );
menuManager.update( true );