You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/06/15 16:08:38 UTC

[GitHub] [jackrabbit-filevault] Buuhuu commented on pull request #228: JCRVLT-637

Buuhuu commented on PR #228:
URL: https://github.com/apache/jackrabbit-filevault/pull/228#issuecomment-1156663392

   Yes, as [said earlier](https://github.com/apache/jackrabbit-filevault/pull/227#issuecomment-1156124727), this should work
   
   > We could also remove this [line](https://github.com/apache/jackrabbit-filevault/blob/jackrabbit-filevault-3.6.0/vault-validation/src/main/java/org/apache/jackrabbit/vault/validation/spi/impl/DocumentViewParserValidator.java#L105), but there is a unit test that validates this behaviour of the DocumentViewParserValidator so I assume that would be a breaking change.
   
   With that you can remove `testGenericJcrDataWithBinaryFileDetected()` as this should now be covered by `testGenericJcrData()` already. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org