You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/06/25 08:07:45 UTC

[GitHub] [submarine] jiwq commented on a change in pull request #328: SUBMARINE-545. Changes of top level K8s README to make it easier to read

jiwq commented on a change in pull request #328:
URL: https://github.com/apache/submarine/pull/328#discussion_r445381022



##########
File path: docs/userdocs/k8s/README.md
##########
@@ -22,19 +22,40 @@ Submarine for K8s supports distributed TensorFlow and PyTorch.
 
 Submarine can run on K8s >= 1.14, supports features like GPU isolation.
 
+We have validated Submarine on the following versions:
+
+[FIXME]: is it accurate?

Review comment:
       LGTM, I had verified 14/15/16 version.

##########
File path: docs/userdocs/k8s/README.md
##########
@@ -22,19 +22,40 @@ Submarine for K8s supports distributed TensorFlow and PyTorch.
 
 Submarine can run on K8s >= 1.14, supports features like GPU isolation.
 
+We have validated Submarine on the following versions:
+
+[FIXME]: is it accurate?
+
+| K8s Version   | Support?  |
+| ------------- |:-------------:|
+| 1.13.x (or earlier) | X |
+| 1.14.x | √ |
+| 1.15.x | √ |
+| 1.16.x | √ |
+| 1.17.x | To be verified |
+| 1.17.x | To be verified |

Review comment:
       ```suggestion
   | 1.18.x | To be verified |
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org