You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/06 22:59:38 UTC
[GitHub] [solr] janhoy opened a new pull request #732: SOLR-15223 Deprecate HttpSolrClient and friends in 9.0
janhoy opened a new pull request #732:
URL: https://github.com/apache/solr/pull/732
https://issues.apache.org/jira/browse/SOLR-15223
I think we should deprecate this already in 9.0, to give a clear signal for users to start using the Jetty-client equivalents.
We still don't have Http2 equivalents for several of the deprecated classes, so I just wrote "Please consider alternatives involving the new Solr Http2Client", althought there is currently no alternative. I think we should implement those alternatives in 9.1...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy edited a comment on pull request #732: SOLR-15223 Deprecate HttpSolrClient and friends in 9.0
Posted by GitBox <gi...@apache.org>.
janhoy edited a comment on pull request #732:
URL: https://github.com/apache/solr/pull/732#issuecomment-1061606697
> I'm skeptical we should deprecate SolrStream and maybe another class or two
Probably makes sense. Will remove deprecated annotation for a few classes. Created https://issues.apache.org/jira/browse/SOLR-16087 to followup moving streaming to the Http2 clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #732: SOLR-15223 Deprecate HttpSolrClient and friends in 9.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #732:
URL: https://github.com/apache/solr/pull/732#discussion_r821535941
##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientCloudManager.java
##########
@@ -47,7 +47,13 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/** Class that implements {@link SolrCloudManager} using a SolrClient */
+/**
+ * Class that implements {@link SolrCloudManager} using a SolrClient. TODO: Write a Http2 version of
+ * this class
+ *
+ * @deprecated Please look into using Solr's new Http2 clients
+ */
+@Deprecated(since = "9.0")
Review comment:
Perhaps this class also can survive, if it is updated to use `CloudHttp2SolrClient`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #732: SOLR-15223 Deprecate HttpSolrClient and friends in 9.0
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #732:
URL: https://github.com/apache/solr/pull/732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #732: SOLR-15223 Deprecate HttpSolrClient and friends in 9.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #732:
URL: https://github.com/apache/solr/pull/732#issuecomment-1061606697
> I'm skeptical we should deprecate SolrStream and maybe another class or two
Probably makes sense. We should create JIRAs for switching over these classes to the Jetty client. I'm not familiar with SolrStream class but assume it is an easy switch that can be done any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org