You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by br...@apache.org on 2014/06/06 21:38:50 UTC
svn commit: r1600990 - in /subversion/trunk/subversion/bindings/javahl:
src/org/tigris/subversion/javahl/SVNClient.java
tests/org/tigris/subversion/javahl/SVNTests.java
Author: brane
Date: Fri Jun 6 19:38:49 2014
New Revision: 1600990
URL: http://svn.apache.org/r1600990
Log:
Fix a couple bugs in the old org.tigris authentication callback implementation
in JavaHL, which were exposed by the authn callback changes.
[in subversion/bindings/javahl]
* src/org/tigris/subversion/javahl/SVNClient.java
(SVNClient.PromptUser1Wrapper.userAllowedSave): Forward the call to the
prompter, if it supports this method.
* tests/org/tigris/subversion/javahl/SVNTests.java
(SVNTest.DefaultPromptUserPassword.prompt): Return true, indicating success,
not false, which indicates cancellation.
Modified:
subversion/trunk/subversion/bindings/javahl/src/org/tigris/subversion/javahl/SVNClient.java
subversion/trunk/subversion/bindings/javahl/tests/org/tigris/subversion/javahl/SVNTests.java
Modified: subversion/trunk/subversion/bindings/javahl/src/org/tigris/subversion/javahl/SVNClient.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/tigris/subversion/javahl/SVNClient.java?rev=1600990&r1=1600989&r2=1600990&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/tigris/subversion/javahl/SVNClient.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/tigris/subversion/javahl/SVNClient.java Fri Jun 6 19:38:49 2014
@@ -377,7 +377,10 @@ public class SVNClient implements SVNCli
public boolean userAllowedSave()
{
- return false;
+ if (oldPrompt3 != null)
+ return oldPrompt3.userAllowedSave();
+ else
+ return false;
}
public String askQuestion(String realm, String question,
Modified: subversion/trunk/subversion/bindings/javahl/tests/org/tigris/subversion/javahl/SVNTests.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/tests/org/tigris/subversion/javahl/SVNTests.java?rev=1600990&r1=1600989&r2=1600990&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/tests/org/tigris/subversion/javahl/SVNTests.java (original)
+++ subversion/trunk/subversion/bindings/javahl/tests/org/tigris/subversion/javahl/SVNTests.java Fri Jun 6 19:38:49 2014
@@ -309,12 +309,12 @@ class SVNTests extends TestCase
public boolean prompt(String realm, String username)
{
- return false;
+ return true;
}
public boolean prompt(String realm, String username, boolean maySave)
{
- return false;
+ return true;
}
public String askQuestion(String realm, String question,