[M] Change in asterixdb[master]: [NO ISSUE][COMP] Improve ANALYZE and ADVISE errors on external collec...

[AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>]

From Rithwik Koul <ri...@couchbase.com>:

Attention is currently required from: Rithwik Koul.

Hello Anon. E. Moose #1000171, Jenkins, 

I'd like you to reexamine a change. Please visit

    https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21609?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Contrib-2 by Anon. E. Moose #1000171, Integration-Tests-1 by Jenkins, Verified-1 by Jenkins


Change subject: [NO ISSUE][COMP] Improve ANALYZE and ADVISE errors on external collections
......................................................................

[NO ISSUE][COMP] Improve ANALYZE and ADVISE errors on external collections

- user model changes: no
- storage format changes: no
- interface changes: no

ANALYZE on a collection that is not internal reported the generic
"Operation not supported" error, and ADVISE over a collection without a
sample always suggested running ANALYZE on that collection, which is
misleading for external collections since samples cannot be collected on
them. Report a dedicated error naming the collection in both cases, and
keep the generic error for the remaining collection types.

Ex-ref: MB-73472
Change-Id: I553b54a2a8f5594975650c1d8ec8e7b74655857a
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cbo-join/CBOJoinQueries.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cbo-join/index-advisor/external-collection-advise/external-collection-advise.1.ddl.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cbo-join/index-advisor/external-collection-advise/external-collection-advise.2.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/analyze-dataset-external/analyze-dataset-external.1.ddl.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/analyze-dataset-external/analyze-dataset-external.2.ddl.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/analyze-dataset-external/analyze-dataset-external.3.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/sqlpp_queries.xml
M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
13 files changed, 171 insertions(+), 7 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/09/21609/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21609?usp=email
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I553b54a2a8f5594975650c1d8ec8e7b74655857a
Gerrit-Change-Number: 21609
Gerrit-PatchSet: 2
Gerrit-Owner: Rithwik Koul <ri...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Attention: Rithwik Koul <ri...@couchbase.com>