You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/22 14:02:44 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #8882:
[docker] Fix for #8880
dpgaspar opened a new pull request #8882: [docker] Fix for #8880
URL: https://github.com/apache/incubator-superset/pull/8882
### CATEGORY
- [X] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Quick fix for #8880 introduced on #8863. We can revert the PR merge this or find a different solution.
Seems like docker does not support this level of indirection on environment files.
I wonder if it defeats the attempt made to make switching databases more easy since now we are duplicating variables.
### ADDITIONAL INFORMATION
- [X] Has associated issue: 8880
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@craig-rueda
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8882: [docker]
Fix for #8880
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8882: [docker] Fix for #8880
URL: https://github.com/apache/incubator-superset/pull/8882#issuecomment-568266657
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8882?src=pr&el=h1) Report
> Merging [#8882](https://codecov.io/gh/apache/incubator-superset/pull/8882?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/36c6f4ca3adfb237e1a4931563b782a4d7e7932a?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8882?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8882 +/- ##
=======================================
Coverage 58.97% 58.97%
=======================================
Files 359 359
Lines 11333 11333
Branches 2787 2787
=======================================
Hits 6684 6684
Misses 4471 4471
Partials 178 178
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8882?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8882?src=pr&el=footer). Last update [36c6f4c...e6e906e](https://codecov.io/gh/apache/incubator-superset/pull/8882?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #8882: [docker]
Fix for #8880
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #8882: [docker] Fix for #8880
URL: https://github.com/apache/incubator-superset/pull/8882
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org