You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2022/04/19 19:44:28 UTC

[GitHub] [tomee-site-generator] sultan opened a new pull request, #40: TOMEE-3917 update javadoc to reflect update to MicroProfile 5.0

sultan opened a new pull request, #40:
URL: https://github.com/apache/tomee-site-generator/pull/40

   updating javadoc at website https://tomee.apache.org/docs.html
   
   replace jakartaee-9.0 by jakartaee-9.1 and add microprofile-5.0 and 4.1
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tomee-site-generator] rzo1 commented on a diff in pull request #40: TOMEE-3917 update javadoc to reflect update to MicroProfile 5.0

Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #40:
URL: https://github.com/apache/tomee-site-generator/pull/40#discussion_r856115648


##########
src/main/jbake/content/download.adoc:
##########
@@ -12,8 +12,8 @@ You **must** link:https://www.apache.org/info/verification.html[verify] the inte
 == [[tomee-9.0]]Apache TomEE 9.0
 
 - Jakarta EE 9.1
-- MicroProfile 2.0
-- Java 8 or higher
+- MicroProfile 5.0
+- Java 11 or higher

Review Comment:
   see above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tomee-site-generator] sultan commented on pull request #40: TOMEE-3917 update javadoc to reflect update to MicroProfile 5.0

Posted by GitBox <gi...@apache.org>.
sultan commented on PR #40:
URL: https://github.com/apache/tomee-site-generator/pull/40#issuecomment-1103046791

   Jakarta EE 9 javadoc was taken from master, which is wrong since master is for Jakarta EE Next (10)
   
   @dblevins i will do it manually, unless you have a tag similar to EE4J_8 for V9.1 for every sub-spec (e.g. https://github.com/eclipse-ee4j/common-annotations-api/tree/EE4J_8 , etc ) 
   
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tomee-site-generator] rzo1 commented on pull request #40: TOMEE-3917 update javadoc to reflect update to MicroProfile 5.0

Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #40:
URL: https://github.com/apache/tomee-site-generator/pull/40#issuecomment-1106401057

   @sultan Thanks for the PR and the pointer. I left some minor comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tomee-site-generator] sultan commented on pull request #40: TOMEE-3917 update javadoc to reflect update to MicroProfile 5.0

Posted by GitBox <gi...@apache.org>.
sultan commented on PR #40:
URL: https://github.com/apache/tomee-site-generator/pull/40#issuecomment-1103882362

   Jakarta EE 8 has RPC, does Jakarta EE 9 and 10 include RPC 1.1.4 ?
   what is JAXR ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tomee-site-generator] rzo1 commented on a diff in pull request #40: TOMEE-3917 update javadoc to reflect update to MicroProfile 5.0

Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #40:
URL: https://github.com/apache/tomee-site-generator/pull/40#discussion_r856112499


##########
src/main/jbake/content/download.adoc:
##########
@@ -12,8 +12,8 @@ You **must** link:https://www.apache.org/info/verification.html[verify] the inte
 == [[tomee-9.0]]Apache TomEE 9.0
 
 - Jakarta EE 9.1
-- MicroProfile 2.0

Review Comment:
   While this change is true for the current M8-SNAPSHOT, it isn't for the latest M7 release, which bundles the old MP versions. In addition, it is compiled against Java 11 as we used byte code transformation of TomEE 8 to create M7. 
   
   I would suggest to drop this particular change until we have an M8 or final release.



##########
src/main/jbake/content/download.adoc:
##########
@@ -12,8 +12,8 @@ You **must** link:https://www.apache.org/info/verification.html[verify] the inte
 == [[tomee-9.0]]Apache TomEE 9.0
 
 - Jakarta EE 9.1
-- MicroProfile 2.0

Review Comment:
   While this change is true for the current M8-SNAPSHOT, it isn't for the latest M7 release, which bundles the old MP versions. In addition, it is compiled against Java 11 as we used byte code transformation of TomEE 8 to create M7. 
   
   I would suggest to drop this particular change until we have an M8 or final release.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tomee-site-generator] sultan commented on pull request #40: TOMEE-3917 update javadoc to reflect update to MicroProfile 5.0

Posted by GitBox <gi...@apache.org>.
sultan commented on PR #40:
URL: https://github.com/apache/tomee-site-generator/pull/40#issuecomment-1106416378

   agreed ! download page reverted back to reflect M7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tomee-site-generator] rzo1 merged pull request #40: TOMEE-3917 update javadoc to reflect update to MicroProfile 5.0

Posted by GitBox <gi...@apache.org>.
rzo1 merged PR #40:
URL: https://github.com/apache/tomee-site-generator/pull/40


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org