You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by orpiske <gi...@git.apache.org> on 2018/10/31 10:41:09 UTC
[GitHub] activemq-artemis pull request #2406: New profile to allow skipping or includ...
GitHub user orpiske opened a pull request:
https://github.com/apache/activemq-artemis/pull/2406
New profile to allow skipping or including the execution of integration tests
This comes as request from our team. They would like to be able to skip and/or include the execution of the integration tests on demand.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/orpiske/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2406.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2406
----
commit 9490e745c5431e681c768e6fdd20ed5dda0b7b95
Author: Otavio Rodolfo Piske <op...@...>
Date: 2018-10-31T08:40:38Z
Create a new profile to allow skipping or including the execution of integration tests
----
---
[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...
Posted by orpiske <gi...@git.apache.org>.
Github user orpiske commented on the issue:
https://github.com/apache/activemq-artemis/pull/2406
We have tried the proposed approach and it did not skip the integration tests. We received a suggestion from @andytaylor to use "-PDev" in addition to that. Any solution that does not involve code changes would be preferred, indeed.
---
[GitHub] activemq-artemis pull request #2406: New profile to allow skipping or includ...
Posted by orpiske <gi...@git.apache.org>.
Github user orpiske closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2406
---
[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2406
There is a script. One-test.sh. Or you can run the test in an ide.
---
[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2406
This is not needed at all. can you close it?
---
[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2406
how to run a single test:
```
mvn -Ptests -DfailIfNoTests=false -Pextra-tests -DskipStyleCheck=true -DskipPerformanceTests=false -Dtest=$1 test
```
^^^ the following is provided as ./scripts/one-test.sh from main.
and TBH: most people just use the IDE to start a single test.
or if you just want to run the integration-tests, you can call mvn -Ptests within integration-tests
I really don't see a reason for this profile.
---
[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...
Posted by orpiske <gi...@git.apache.org>.
Github user orpiske commented on the issue:
https://github.com/apache/activemq-artemis/pull/2406
> how to run a single test:
>
> ```
> mvn -Ptests -DfailIfNoTests=false -Pextra-tests -DskipStyleCheck=true -DskipPerformanceTests=false -Dtest=$1 test
> ```
>
> ^^^ the following is provided as ./scripts/one-test.sh from main.
>
> and TBH: most people just use the IDE to start a single test.
>
> or if you just want to run the integration-tests, you can call mvn -Ptests within integration-tests
>
> I really don't see a reason for this profile.
The primary reason is that they want to run a couple of tests (without the integration ones) on the CI.
That said: I see no reason to struggle with this without having exhausted other possibilities. I will close this PR and will point them to this as a source of some ideas. If nothing comes up that satisfies them, then we can re discuss this on better grounds.
---