You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/28 14:17:28 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #23329: Improve react www tests
bbovenzi opened a new pull request, #23329:
URL: https://github.com/apache/airflow/pull/23329
- Move wrappers for react tests to a shared component
- Add placeholderData for `useTreeData` and remove the need for adding default values every time the hook is called
- Use `URLSearchParams` for `useTreeData` instead of manually creating the param string
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #23329: Improve react www tests
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #23329:
URL: https://github.com/apache/airflow/pull/23329#discussion_r861069790
##########
airflow/www/static/js/tree/api/useTreeData.js:
##########
@@ -29,24 +29,30 @@ import useErrorToast from '../useErrorToast';
// dagId comes from dag.html
const dagId = getMetaValue('dag_id');
-const treeDataUrl = getMetaValue('tree_data_url');
+const treeDataUrl = getMetaValue('tree_data_url') || '';
Review Comment:
This is so treeDataUrl is a string rather than undefined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on a diff in pull request #23329: Improve react www tests
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on code in PR #23329:
URL: https://github.com/apache/airflow/pull/23329#discussion_r863113465
##########
airflow/www/static/js/tree/utils/testUtils.jsx:
##########
@@ -0,0 +1,69 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { ChakraProvider, Table, Tbody } from '@chakra-ui/react';
+import { QueryClient, QueryClientProvider } from 'react-query';
+import { MemoryRouter } from 'react-router-dom';
+// eslint-disable-next-line import/no-extraneous-dependencies
+import moment from 'moment-timezone';
+
+import { ContainerRefProvider } from '../context/containerRef';
+import { TimezoneProvider } from '../context/timezone';
+import { AutoRefreshProvider } from '../context/autorefresh';
+
+global.moment = moment;
+
+const Wrapper = ({ children }) => {
Review Comment:
WDYT about only using named exports instead of one named and one default? It makes for an inconsistent import. e.g.
```jsx
import Wrapper from '../utils/testUtils';
```
vs.
```jsx
import { TableWrapper } from './utils/testUtils';
```
```suggestion
export const Wrapper = ({ children }) => {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #23329: Improve react www tests
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #23329:
URL: https://github.com/apache/airflow/pull/23329#discussion_r863108075
##########
airflow/www/static/js/tree/api/useTreeData.js:
##########
@@ -29,24 +29,30 @@ import useErrorToast from '../useErrorToast';
// dagId comes from dag.html
const dagId = getMetaValue('dag_id');
-const treeDataUrl = getMetaValue('tree_data_url');
+const treeDataUrl = getMetaValue('tree_data_url') || '';
Review Comment:
Actually, this is a simple enough of a solution. We will change how we get the urls soon with [#23422](https://github.com/apache/airflow/issues/23422)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #23329: Improve react www tests
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #23329:
URL: https://github.com/apache/airflow/pull/23329#discussion_r861071908
##########
airflow/www/static/js/tree/api/useTreeData.js:
##########
@@ -29,24 +29,30 @@ import useErrorToast from '../useErrorToast';
// dagId comes from dag.html
const dagId = getMetaValue('dag_id');
-const treeDataUrl = getMetaValue('tree_data_url');
+const treeDataUrl = getMetaValue('tree_data_url') || '';
Review Comment:
Yes, this was to fix a test error. Let me think if there is a more appropriate way to handle that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23329: Improve react www tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23329:
URL: https://github.com/apache/airflow/pull/23329#issuecomment-1115281380
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #23329: Improve react www tests
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #23329:
URL: https://github.com/apache/airflow/pull/23329#discussion_r863123421
##########
airflow/www/static/js/tree/utils/testUtils.jsx:
##########
@@ -0,0 +1,69 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { ChakraProvider, Table, Tbody } from '@chakra-ui/react';
+import { QueryClient, QueryClientProvider } from 'react-query';
+import { MemoryRouter } from 'react-router-dom';
+// eslint-disable-next-line import/no-extraneous-dependencies
+import moment from 'moment-timezone';
+
+import { ContainerRefProvider } from '../context/containerRef';
+import { TimezoneProvider } from '../context/timezone';
+import { AutoRefreshProvider } from '../context/autorefresh';
+
+global.moment = moment;
+
+const Wrapper = ({ children }) => {
Review Comment:
Good call. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #23329: Improve react www tests
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #23329:
URL: https://github.com/apache/airflow/pull/23329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org