You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2010/03/02 15:40:28 UTC
DO NOT REPLY [Bug 48841] New: mod_proxy: Allow loadfactor of 0.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48841
Summary: mod_proxy: Allow loadfactor of 0.
Product: Apache httpd-2
Version: 2.2-HEAD
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P2
Component: mod_proxy
AssignedTo: bugs@httpd.apache.org
ReportedBy: cameron.stokes@ihg.com
mod_proxy only allows a BalancerMember's loadfactor to be set to a value
between 1 and 100. Ideally, loadfactor should be allowed to be set to 0 so
that a BalancerMember can be removed from new traffic but allowed to keep
servicing existing sessions (i.e. bleeding off sessions) or to be able to start
a BalancerMember and test it before letting new traffic access it.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 48841] mod_proxy: Allow loadfactor of 0.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48841
--- Comment #7 from Keith Mashinter <km...@yahoo.com> 2011-10-02 14:46:10 UTC ---
In my related enhancement I've attached a backport patch for the
PROXY_WORKER_DRAIN status to the 2.2.21 code base.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51247
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 48841] mod_proxy: Allow loadfactor of 0.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48841
Daniel Ruggeri <DR...@primary.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |DRuggeri@primary.net
--- Comment #1 from Daniel Ruggeri <DR...@primary.net> 2010-04-05 20:56:17 UTC ---
Cameron;
I am attaching a patch to do this. This will add the functionality you
describe to the balancer manager and to the initial configuration. Please apply
the patch if you can and let me know how you get on.
Devs;
I used a constant called PROXY_WORKER_NOLBFACTOR in mod_proxy.h and changed
the atoi call during configuration to strtol since atoi. I did this because the
atoi call returns 0 both during error situations and when the proper value to
return is 0. Also, the existing checks had to be refactored a little since (at
least on the SUN c compiler) an uninitialized integer is the same as `0'. Aside
from that, only the bybusiness algorithm had to be modified to avoid a divide
by zero error.
I welcome your comments.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 48841] mod_proxy: Allow loadfactor of 0.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48841
--- Comment #4 from Earnest Jackson <ej...@gmail.com> 2011-06-02 19:35:59 UTC ---
How would this patch be applied? Has this patch been moved into versions like
2.2.17, .18, etc?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 48841] mod_proxy: Allow loadfactor of 0.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48841
Jim Jagielski <ji...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #5 from Jim Jagielski <ji...@apache.org> 2011-09-15 11:10:24 UTC ---
The Drain setting has been added to trunk and will be in 2.4.0GA.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 48841] mod_proxy: Allow loadfactor of 0.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48841
--- Comment #10 from Sebb <se...@apache.org> ---
(In reply to comment #9)
> Bug 51247 is the actual fix applied to trunk and 2.4, where a 'Drain' flag
> was added to mod_proxy_balancer members.
>
> *** This bug has been marked as a duplicate of bug 52147 ***
*** This bug has been marked as a duplicate of bug 51247 ***
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 48841] mod_proxy: Allow loadfactor of 0.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48841
--- Comment #2 from Daniel Ruggeri <DR...@primary.net> 2010-04-05 20:57:56 UTC ---
Created an attachment (id=25230)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=25230)
Allows lbfactor to be set to zero in configuration and balancer manager
My test cases showed that all algorithms worked as expected. The obvious
exception is if a sticky cookie is discovered that will kick the request to the
worker, ignoring any algorithms.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 48841] mod_proxy: Allow loadfactor of 0.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48841
Daniel Ruggeri <DR...@primary.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 48841] mod_proxy: Allow loadfactor of 0.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48841
William A. Rowe Jr. <wr...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |DUPLICATE
--- Comment #9 from William A. Rowe Jr. <wr...@apache.org> ---
Bug 51247 is the actual fix applied to trunk and 2.4, where a 'Drain' flag
was added to mod_proxy_balancer members.
*** This bug has been marked as a duplicate of bug 52147 ***
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 48841] mod_proxy: Allow loadfactor of 0.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48841
William A. Rowe Jr. <wr...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #8 from William A. Rowe Jr. <wr...@apache.org> ---
Reopening to tag the correct bug as 'fixed'.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 48841] mod_proxy: Allow loadfactor of 0.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48841
Keith Mashinter <km...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmashint@yahoo.com
--- Comment #6 from Keith Mashinter <km...@yahoo.com> 2011-09-20 11:34:27 UTC ---
*** Bug 51247 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 48841] mod_proxy: Allow loadfactor of 0.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48841
--- Comment #3 from Daniel Ruggeri <DR...@primary.net> 2011-05-25 19:58:13 UTC ---
Patch notes and 'splaining:
I used a constant called PROXY_WORKER_NOLBFACTOR in mod_proxy.h and changed the
atoi call during configuration to strtol since the atoi call returns 0 both
during error situations and when the proper value to return is 0. Also, the
existing checks had to be refactored a little since (at least on the SUN c
compiler) an uninitialized integer is the same as `0'. Aside from that, only
the bybusiness algorithm had to be modified to avoid a divide by zero error.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org