You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/01/24 03:59:58 UTC
[kudu-CR] [security] moved x509 check host under ca sub-dir
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5777
Change subject: [security] moved x509_check_host under ca sub-dir
......................................................................
[security] moved x509_check_host under ca sub-dir
There are no functional changes in this commit.
Change-Id: Ifb781cbc2451431dac4c8f109f1396f671c44242
---
M src/kudu/security/CMakeLists.txt
R src/kudu/security/ca/x509_check_host.cc
R src/kudu/security/ca/x509_check_host.h
M src/kudu/security/ssl_socket.cc
4 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/5777/1
--
To view, visit http://gerrit.cloudera.org:8080/5777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb781cbc2451431dac4c8f109f1396f671c44242
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [security] moved x509 check host under ca sub-dir
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [security] moved x509_check_host under ca sub-dir
......................................................................
Patch Set 1:
hm, what's the logic here? 'ca' sounds like it should be code used by a certificate authority, but x509_check_host is used by all TLS clients (if anything I'd expect it in a tls/ directory or an x509/ dir or something)
--
To view, visit http://gerrit.cloudera.org:8080/5777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb781cbc2451431dac4c8f109f1396f671c44242
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [security] moved x509 check host under ca sub-dir
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has abandoned this change.
Change subject: [security] moved x509_check_host under ca sub-dir
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/5777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ifb781cbc2451431dac4c8f109f1396f671c44242
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security] moved x509 check host under ca sub-dir
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [security] moved x509_check_host under ca sub-dir
......................................................................
Patch Set 1:
> hm, what's the logic here? 'ca' sounds like it should be code used
> by a certificate authority, but x509_check_host is used by all TLS
> clients (if anything I'd expect it in a tls/ directory or an x509/
> dir or something)
We talked about moving everything X509-related into the security/ca subdir. But I agree, that does not make sense.
--
To view, visit http://gerrit.cloudera.org:8080/5777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb781cbc2451431dac4c8f109f1396f671c44242
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No