You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2020/01/23 07:32:45 UTC

[impala] 02/02: IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3

This is an automated email from the ASF dual-hosted git repository.

stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 3d10e8abbe9bc309c1436af1a6fa049589760a0e
Author: stiga-huang <hu...@gmail.com>
AuthorDate: Thu Jan 23 08:50:26 2020 +0800

    IMPALA-9287: Skip test_kudu_table_create_without_hms in Hive3
    
    test_kudu_table_create_without_hms fails when using Hive3. The test
    failure leaves the minicluster in a weird state since it restarts Hive
    to use a different configuration. Skip this test until it's fixed.
    
    Tests:
     - Run test_kudu_table_create_without_hms.py and verify it's skipped.
    
    Change-Id: I88dce9e3afabb59b8dadd6f0356e6cc99e9dc9f4
    Reviewed-on: http://gerrit.cloudera.org:8080/15093
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/common/skip.py                                       | 3 +++
 tests/custom_cluster/test_kudu_table_create_without_hms.py | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/tests/common/skip.py b/tests/common/skip.py
index 3729649..4d6aecf 100644
--- a/tests/common/skip.py
+++ b/tests/common/skip.py
@@ -217,6 +217,9 @@ class SkipIfHive3:
       reason="Kudu is not tested with Hive 3 notifications yet, see IMPALA-8751.")
   col_stat_separated_by_engine = pytest.mark.skipif(HIVE_MAJOR_VERSION >= 3,
       reason="Hive 3 separates column statistics by engine")
+  without_hms_not_supported = pytest.mark.skipif(HIVE_MAJOR_VERSION >= 3,
+      reason="Instantiating HMS server in embedded mode within Hive client requires more "
+             "dependencies of Hive 3, see IMPALA-9287.")
 
 
 class SkipIfHive2:
diff --git a/tests/custom_cluster/test_kudu_table_create_without_hms.py b/tests/custom_cluster/test_kudu_table_create_without_hms.py
index 1fc553b..cfe957e 100644
--- a/tests/custom_cluster/test_kudu_table_create_without_hms.py
+++ b/tests/custom_cluster/test_kudu_table_create_without_hms.py
@@ -19,6 +19,7 @@ import pytest
 import os
 
 from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
+from tests.common.skip import SkipIfHive3
 
 IMPALA_HOME = os.getenv('IMPALA_HOME')
 HIVE_SITE_WITHOUT_HMS_DIR = IMPALA_HOME + '/fe/src/test/resources/hive-site-without-hms'
@@ -28,6 +29,7 @@ TBL_NAME = "test_kudu_table_create_without_hms"
 class TestCreatingKuduTableWithoutHMS(CustomClusterTestSuite):
   """Test creating kudu managed table without hms"""
 
+  @SkipIfHive3.without_hms_not_supported
   @pytest.mark.execute_serially
   @CustomClusterTestSuite.with_args(hive_conf_dir=HIVE_SITE_WITHOUT_HMS_DIR)
   def test_kudu_table_create_without_hms(self, unique_database):