You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "David E. Jones" <jo...@undersunconsulting.com> on 2007/01/26 21:30:58 UTC

Re: svn commit: r500328 - in /ofbiz/trunk/framework: shark/src/org/ofbiz/shark/container/SharkContainer.java webtools/webapp/webtools/entity/ModelInduceFromDb.jsp webtools/webapp/webtools/entity/ModelWriter.jsp

Jacques,

Those copyright statements are fine to change that way. In general  
these are just defaults and no mandatory, so we might want to  
consider removing even them at some point. For now I don't see any  
harm in reminding people of the Apache world OFBiz lives in.

-David


On Jan 26, 2007, at 1:24 PM, jleroux@apache.org wrote:

> Author: jleroux
> Date: Fri Jan 26 12:24:07 2007
> New Revision: 500328
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=500328
> Log:
> I noticed an author reference in the Shark component this during  
> review but forgot to make and commit the change.
> This was part of https://issues.apache.org/jira/browse/OFBIZ-637  
> (already closed)
>
> In the same time I looked for other author references and found  
> non : there are no author references in all OFBiz.
> But I found a couple of OFBiz pre-Apache references in 2 jsp files.  
> Not sure they are always used but I fixed them.
>
> Modified:
>     ofbiz/trunk/framework/shark/src/org/ofbiz/shark/container/ 
> SharkContainer.java
>     ofbiz/trunk/framework/webtools/webapp/webtools/entity/ 
> ModelInduceFromDb.jsp
>     ofbiz/trunk/framework/webtools/webapp/webtools/entity/ 
> ModelWriter.jsp
>
> Modified: ofbiz/trunk/framework/shark/src/org/ofbiz/shark/container/ 
> SharkContainer.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/shark/src/ 
> org/ofbiz/shark/container/SharkContainer.java? 
> view=diff&rev=500328&r1=500327&r2=500328
> ====================================================================== 
> ========
> --- ofbiz/trunk/framework/shark/src/org/ofbiz/shark/container/ 
> SharkContainer.java (original)
> +++ ofbiz/trunk/framework/shark/src/org/ofbiz/shark/container/ 
> SharkContainer.java Fri Jan 26 12:24:07 2007
> @@ -50,13 +50,6 @@
>   * Shark Workflow Engine Container
>   */
>
> -
> -/**
> - * Shark Workflow Engine Container
> - *
> - * @author     <a href="mailto:jaz@ofbiz.org">Andy Zeneski</a>
> - * @since      3.1
> - */
>  public class SharkContainer implements Container, Runnable
>  {
>      public static final String module =  
> SharkContainer.class.getName();
>
> Modified: ofbiz/trunk/framework/webtools/webapp/webtools/entity/ 
> ModelInduceFromDb.jsp
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/ 
> webapp/webtools/entity/ModelInduceFromDb.jsp? 
> view=diff&rev=500328&r1=500327&r2=500328
> ====================================================================== 
> ========
> --- ofbiz/trunk/framework/webtools/webapp/webtools/entity/ 
> ModelInduceFromDb.jsp (original)
> +++ ofbiz/trunk/framework/webtools/webapp/webtools/entity/ 
> ModelInduceFromDb.jsp Fri Jan 26 12:24:07 2007
> @@ -47,9 +47,9 @@
>          }
>        }
>        if(newEntList != null) {
> -        String title = "Entity of an Open For Business Project  
> Component";
> +        String title = "Entity of an Apache Open For Business  
> Project (Apache OFBiz) Component";
>          String description = "None";
> -        String copyright = "Copyright (c) 2001 The Open For  
> Business Project - www.ofbiz.org";
> +        String copyright = "Copyright 2001-2006 The Apache  
> Software Foundation";
>          String author = "None";
>          String version = "1.0";
>  %><?xml version="1.0" encoding="UTF-8"?>
>
> Modified: ofbiz/trunk/framework/webtools/webapp/webtools/entity/ 
> ModelWriter.jsp
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/ 
> webapp/webtools/entity/ModelWriter.jsp? 
> view=diff&rev=500328&r1=500327&r2=500328
> ====================================================================== 
> ========
> --- ofbiz/trunk/framework/webtools/webapp/webtools/entity/ 
> ModelWriter.jsp (original)
> +++ ofbiz/trunk/framework/webtools/webapp/webtools/entity/ 
> ModelWriter.jsp Fri Jan 26 12:24:07 2007
> @@ -60,11 +60,11 @@
>        }
>      }
>    } else {
> -    String title = "Entity of an Open For Business Project  
> Component";
> -    String description = "None";
> -    String copyright = "Copyright (c) 2002 The Open For Business  
> Project - www.ofbiz.org";
> -    String author = "None";
> -    String version = "1.0";
> +      String title = "Entity of an Apache Open For Business  
> Project (Apache OFBiz) Component";
> +      String description = "None";
> +      String copyright = "Copyright 2001-2006 The Apache Software  
> Foundation";
> +      String author = "None";
> +      String version = "1.0";
>  %><?xml version="1.0" encoding="UTF-8"?>
>  <!DOCTYPE entitymodel PUBLIC "-//OFBiz//DTD Entity Model//EN"  
> "http://www.ofbiz.org/dtds/entitymodel.dtd">
>  <!--
>
>