You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/27 05:05:08 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request #7617: refactor AlterIndexStatement, DropIndexStatement to different dialect Statement

strongduanmu opened a new pull request #7617:
URL: https://github.com/apache/shardingsphere/pull/7617


   Fixes #7170.
   
   Changes proposed in this pull request:
   - refactor AlterIndexStatement, DropIndexStatement to different dialect Statement
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero merged pull request #7617: refactor AlterIndexStatement, DropIndexStatement to different dialect Statement

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #7617:
URL: https://github.com/apache/shardingsphere/pull/7617


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] coveralls commented on pull request #7617: refactor AlterIndexStatement, DropIndexStatement to different dialect Statement

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7617:
URL: https://github.com/apache/shardingsphere/pull/7617#issuecomment-699588691


   ## Pull Request Test Coverage Report for [Build 15090](https://coveralls.io/builds/33747292)
   
   * **12** of **24**   **(50.0%)**  changed or added relevant lines in **9** files are covered.
   * **2** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.01%**) to **35.133%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/ddl/AlterIndexStatement.java](https://coveralls.io/builds/33747292/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fddl%2FAlterIndexStatement.java#L42) | 0 | 1 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterIndexStatementHandler.java](https://coveralls.io/builds/33747292/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fdialect%2Fhandler%2Fddl%2FAlterIndexStatementHandler.java#L45) | 2 | 3 | 66.67%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/DropIndexStatementHandler.java](https://coveralls.io/builds/33747292/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fdialect%2Fhandler%2Fddl%2FDropIndexStatementHandler.java#L50) | 4 | 5 | 80.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/statement/ddl/DropIndexStatementContext.java](https://coveralls.io/builds/33747292/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fstatement%2Fddl%2FDropIndexStatementContext.java#L44) | 0 | 4 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/statement/ddl/AlterIndexStatementContext.java](https://coveralls.io/builds/33747292/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fstatement%2Fddl%2FAlterIndexStatementContext.java#L44) | 0 | 5 | 0.0%
   <!-- | **Total:** | **12** | **24** | **50.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/statement/ddl/AlterIndexStatementContext.java](https://coveralls.io/builds/33747292/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fstatement%2Fddl%2FAlterIndexStatementContext.java#L46) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/statement/ddl/DropIndexStatementContext.java](https://coveralls.io/builds/33747292/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fstatement%2Fddl%2FDropIndexStatementContext.java#L46) | 1 | 0% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/33747292/badge)](https://coveralls.io/builds/33747292) |
   | :-- | --: |
   | Change from base [Build 15089](https://coveralls.io/builds/33746973): |  0.01% |
   | Covered Lines: | 36655 |
   | Relevant Lines: | 104331 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org