You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/18 15:41:30 UTC

[GitHub] [incubator-nuttx] anchao opened a new pull request, #7128: arch/arm/makefile: linking libraries with GCC should use option -l

anchao opened a new pull request, #7128:
URL: https://github.com/apache/incubator-nuttx/pull/7128

   ## Summary
   
   arch/arm/makefile: linking libraries with GCC should use option -l
   
   Signed-off-by: chao an <an...@xiaomi.com>
   
   ## Impact
   
   N/A
   
   ## Testing
   
   ci check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7128: arch/arm/makefile: linking libraries with GCC should use option -l

Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #7128:
URL: https://github.com/apache/incubator-nuttx/pull/7128#discussion_r973750745


##########
arch/arm/src/Makefile:
##########
@@ -106,6 +107,8 @@ else
   SCRIPT_OPT  = --scatter=
 endif
 
+LIBRARY_OPT  ?= --library=

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7128: arch/arm/makefile: linking libraries with GCC should use option -l

Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #7128:
URL: https://github.com/apache/incubator-nuttx/pull/7128#discussion_r973749179


##########
arch/arm/src/Makefile:
##########
@@ -106,6 +107,8 @@ else
   SCRIPT_OPT  = --scatter=
 endif
 
+LIBRARY_OPT  ?= --library=

Review Comment:
   Yes, or use -l by default, if armlink use --library?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7128: arch/arm/makefile: linking libraries with GCC should use option -l

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7128:
URL: https://github.com/apache/incubator-nuttx/pull/7128#discussion_r973744827


##########
arch/arm/src/Makefile:
##########
@@ -106,6 +107,8 @@ else
   SCRIPT_OPT  = --scatter=
 endif
 
+LIBRARY_OPT  ?= --library=

Review Comment:
   So GCC linking with LD also use this option?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7128: arch/arm/makefile: linking libraries with GCC should use option -l

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7128:
URL: https://github.com/apache/incubator-nuttx/pull/7128


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org