[GitHub] [kafka] showuon commented on a diff in pull request #13653: KAFKA-14946: fix NPE when merging the deltatable

["showuon (via GitHub)" <gi...@apache.org>]

showuon commented on code in PR #13653:
URL: https://github.com/apache/kafka/pull/13653#discussion_r1183102365


##########
server-common/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java:
##########
@@ -113,7 +113,7 @@ public void mergeFrom(long epoch, Delta source) {
             HashTier<T> other = (HashTier<T>) source;
             // As an optimization, the deltaTable might not exist for a new key
             // as there is no previous value
-            if (other.deltaTable != null) {
+            if (deltaTable != null && other.deltaTable != null) {

Review Comment:
   Ah, you are right! We need to copy the other deltatable to `this`. Will update it later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org