You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/02 22:04:00 UTC
[jira] [Commented] (ARTEMIS-1780) AMQP: NPE When dispatching
ObjectMessage that was handled as a Lrage Message
[ https://issues.apache.org/jira/browse/ARTEMIS-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423193#comment-16423193 ]
ASF GitHub Bot commented on ARTEMIS-1780:
-----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1985
ARTEMIS-1780 Handle conversion of large ObjectMessage types
Make sure the correct buffer is used when decoding the stored Core
message that originated from the conversion of an AMQP message sent and
annotated as a JMS ObjectMessage which trips the large message boundary.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1780
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1985.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1985
----
commit 12cdc5c743d07524e1efa68dee4e6fb740f40aaf
Author: Timothy Bish <ta...@...>
Date: 2018-04-02T21:57:54Z
ARTEMIS-1780 Handle conversion of large ObjectMessage types
Make sure the correct buffer is used when decoding the stored Core
message that originated from the conversion of an AMQP message sent and
annotated as a JMS ObjectMessage which trips the large message boundary.
----
> AMQP: NPE When dispatching ObjectMessage that was handled as a Lrage Message
> ----------------------------------------------------------------------------
>
> Key: ARTEMIS-1780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1780
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.5.0
> Reporter: Timothy Bish
> Priority: Major
> Fix For: 2.5.1
>
>
> When JMS ObjectMessage is sent which end up being treated as a large message and is converted to / from Core the dispatch of the message throws an NPE seemingly because the ServerJMSObjectMessage and converter code is calling the wrong method to get the underlying buffer. The other message types go through a getDataBuffer method while the ObjectMessage handler code uses a getBodyBuffer that doesn't account for the case of the message being "Large"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)