You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "vinishjail97 (via GitHub)" <gi...@apache.org> on 2026/10/02 06:00:38 UTC
[PR] fix(metadata): key RLI and SI write stats by file group, not file id [hudi]
vinishjail97 opened a new pull request, #20188:
URL: https://github.com/apache/hudi/pull/20188
### Describe the issue this Pull Request addresses
The record level index and the secondary index group a commit's write stats by `HoodieWriteStat::getFileId` alone. A file group is identified by its partition and file id. For files written outside Hudi, which #19869 registers by their file name, the file id is only unique within a partition. Spark names a file `part-<task>-<job uuid>`, so one task of a `partitionBy` write leaves the same name in every partition it writes. The secondary index then sees several base files under one key and fails with `Only one new parquet file expected per file group per commit`. TPC-DS `store_returns` written by Spark has 2,004 files with 200 distinct names.
### Summary and Changelog
- `SecondaryIndexRecordGenerationUtils` groups write stats by `HoodieFileGroupId` and takes the partition from the key. The replaced file groups it skips are matched by `HoodieFileGroupId` as well.
- `BaseRecordIndexer` groups write stats by `HoodieFileGroupId`.
- `TestExternalFileRecordAndSecondaryIndex#testFilesWithTheSameNameInDifferentPartitions` registers files with the same name in two partitions in one commit and checks both indexes. It fails without the change.
### Impact
None for files written by Hudi, whose file ids are unique across the table.
### Risk Level
low
### Documentation Update
none
### Contributor's checklist
- [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Enough context is provided in the sections above
- [x] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metadata): key RLI and SI write stats by file group, not file id [hudi]
Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on PR #20188:
URL: https://github.com/apache/hudi/pull/20188#issuecomment-6000750925
@voonhous Thanks, you are right: `newBucketFileIdForNBCC` gives a bucket the same file id in every partition. I reworded the description and added `TestSparkNonBlockingConcurrencyControl#testRecordAndSecondaryIndexWithTheSameBucketInDifferentPartitions` in a14aef0f6ad3. It bulk inserts bucket 0 into par1 and par2, then upserts both in one commit with the global record index and the secondary index on. Without the fix the secondary index keeps the old value of the second partition.
The bulk inserts are separate commits: a single NBCC bulk insert into two partitions fails with `Fixed handle create is only expected to be invoked once`, because `RDDSimpleBucketBulkInsertPartitioner` keys its tasks by file id prefix, which is the same in every partition under NBCC. That is the same root cause in the write path, so I'd prefer to handle it in a separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metadata): key RLI and SI write stats by file group, not file id [hudi]
Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on code in PR #20188:
URL: https://github.com/apache/hudi/pull/20188#discussion_r4187462303
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/index/record/BaseRecordIndexer.java:
##########
@@ -392,19 +393,22 @@ public static <T> HoodieData<HoodieRecord> convertMetadataToRecordIndexRecords(H
}
try {
- Map<String, List<HoodieWriteStat>> writeStatsByFileId = allWriteStats.stream().collect(Collectors.groupingBy(HoodieWriteStat::getFileId));
- int parallelism = Math.max(Math.min(writeStatsByFileId.size(), metadataConfig.getRecordIndexMaxParallelism()), 1);
+ // a file group is identified by its partition and file id, the file id alone is only unique within a partition for files
+ // written outside Hudi
+ Map<HoodieFileGroupId, List<HoodieWriteStat>> writeStatsByFileGroupId = allWriteStats.stream()
+ .collect(Collectors.groupingBy(writeStat -> new HoodieFileGroupId(writeStat.getPartitionPath(), writeStat.getFileId())));
+ int parallelism = Math.max(Math.min(writeStatsByFileGroupId.size(), metadataConfig.getRecordIndexMaxParallelism()), 1);
Review Comment:
Good catch, the base file branch already used each write stat's own partition, so the old assertion proved nothing for the record index. Added `TestMetadataUtilRLIandSIRecordGeneration#testRecordIndexRecordsForLogFilesWithTheSameFileIdInDifferentPartitions` in a14aef0f6ad3. It deletes one record in each of two partitions of a MOR table, gives both log file write stats one file id, and checks the partition of each delete from `convertMetadataToRecordIndexRecords` with a partitioned record index. Without the fix both deletes carry the first partition.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/SecondaryIndexRecordGenerationUtils.java:
##########
@@ -263,7 +267,7 @@ private static <T> HoodieData<HoodieRecord> convertReplacedFileGroupsToSecondary
HoodieSchema tableSchema) {
List<Pair<String, String>> replacedFileGroups = replaceCommitMetadata.getPartitionToReplaceFileIds().entrySet().stream()
.flatMap(partitionAndFileIds -> partitionAndFileIds.getValue().stream()
- .filter(fileId -> !writtenFileIds.contains(fileId))
+ .filter(fileId -> !writtenFileGroupIds.contains(new HoodieFileGroupId(partitionAndFileIds.getKey(), fileId)))
Review Comment:
Added in a14aef0f6ad3: a second commit replaces `brazil` while `americas/peru` writes a `part-00000.parquet`, then checks that `bob` and the brazil keys are gone from both indexes. With only the filter reverted, the test fails on the secondary index assertion.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/index/record/BaseRecordIndexer.java:
##########
Review Comment:
Done in a14aef0f6ad3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metadata): key RLI and SI write stats by file group, not file id [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous merged PR #20188:
URL: https://github.com/apache/hudi/pull/20188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metadata): key RLI and SI write stats by file group, not file id [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #20188:
URL: https://github.com/apache/hudi/pull/20188#issuecomment-6002705328
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3997ba9312ac35f06dd0adb5508a350e7839ce15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17419",
"triggerID" : "3997ba9312ac35f06dd0adb5508a350e7839ce15",
"triggerType" : "PUSH"
}, {
"hash" : "a14aef0f6ad3723ab050baf53b613fbb014e3cf9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17456",
"triggerID" : "a14aef0f6ad3723ab050baf53b613fbb014e3cf9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a14aef0f6ad3723ab050baf53b613fbb014e3cf9 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17456)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metadata): key RLI and SI write stats by file group, not file id [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on PR #20188:
URL: https://github.com/apache/hudi/pull/20188#issuecomment-5995485456
No where for me to inline this but:
IIRC, NBCC may also repeat file ids across partitions (`newBucketFileIdForNBCC.`). So, it's not only hive tables or tables outside of hudi that exhibit such behaviours.
Let's reword the PR a little so we don't give the wrong premise. Maybe we can add a test for the NBCC case to `TestSparkNonBlockingConcurrencyControl` bulk_insert into 2 partitions with the record and secondary indexes on, then upsert or delete in both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metadata): key RLI and SI write stats by file group, not file id [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #20188:
URL: https://github.com/apache/hudi/pull/20188#discussion_r4184563578
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/index/record/BaseRecordIndexer.java:
##########
@@ -392,19 +393,22 @@ public static <T> HoodieData<HoodieRecord> convertMetadataToRecordIndexRecords(H
}
try {
- Map<String, List<HoodieWriteStat>> writeStatsByFileId = allWriteStats.stream().collect(Collectors.groupingBy(HoodieWriteStat::getFileId));
- int parallelism = Math.max(Math.min(writeStatsByFileId.size(), metadataConfig.getRecordIndexMaxParallelism()), 1);
+ // a file group is identified by its partition and file id, the file id alone is only unique within a partition for files
+ // written outside Hudi
+ Map<HoodieFileGroupId, List<HoodieWriteStat>> writeStatsByFileGroupId = allWriteStats.stream()
+ .collect(Collectors.groupingBy(writeStat -> new HoodieFileGroupId(writeStat.getPartitionPath(), writeStat.getFileId())));
+ int parallelism = Math.max(Math.min(writeStatsByFileGroupId.size(), metadataConfig.getRecordIndexMaxParallelism()), 1);
Review Comment:
Bew test does not cover the record-index change.
The test `assertRecordndex` will pass with or without the fix here. On master, the record-index base-file branch already processed each write stat with its own partition.
As of now, the test is failing because secondary-index throws, not because of record index.
Can we add a unit case on `convertMetadataToRecordIndexRecords`?
I've asked Claude on how to do it and it says we can do two hand-built `HoodieDeltaWriteStat` that share a file id accross p1 and p2. Then assert each record's partition.
Not sure if there's a better way to do this.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/index/record/BaseRecordIndexer.java:
##########
Review Comment:
NIT: `logFileWriteStats.get(0).getPartitionPath()` -> `writeStatsByFileGroupIdEntry.getKey().getPartitionPath()` ?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/SecondaryIndexRecordGenerationUtils.java:
##########
@@ -263,7 +267,7 @@ private static <T> HoodieData<HoodieRecord> convertReplacedFileGroupsToSecondary
HoodieSchema tableSchema) {
List<Pair<String, String>> replacedFileGroups = replaceCommitMetadata.getPartitionToReplaceFileIds().entrySet().stream()
.flatMap(partitionAndFileIds -> partitionAndFileIds.getValue().stream()
- .filter(fileId -> !writtenFileIds.contains(fileId))
+ .filter(fileId -> !writtenFileGroupIds.contains(new HoodieFileGroupId(partitionAndFileIds.getKey(), fileId)))
Review Comment:
No test that covers replaced file group filter changes.
Can we add a second commit to the new test that replaces `brazil` and writes a `part-00000.parquet` in a third partition, then assert that `bob` is gone from the 2ndary index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metadata): key RLI and SI write stats by file group, not file id [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #20188:
URL: https://github.com/apache/hudi/pull/20188#issuecomment-6001155170
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3997ba9312ac35f06dd0adb5508a350e7839ce15",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17419",
"triggerID" : "3997ba9312ac35f06dd0adb5508a350e7839ce15",
"triggerType" : "PUSH"
}, {
"hash" : "a14aef0f6ad3723ab050baf53b613fbb014e3cf9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17456",
"triggerID" : "a14aef0f6ad3723ab050baf53b613fbb014e3cf9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3997ba9312ac35f06dd0adb5508a350e7839ce15 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17419)
* a14aef0f6ad3723ab050baf53b613fbb014e3cf9 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17456)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metadata): key RLI and SI write stats by file group, not file id [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #20188:
URL: https://github.com/apache/hudi/pull/20188#issuecomment-6001036977
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3997ba9312ac35f06dd0adb5508a350e7839ce15",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17419",
"triggerID" : "3997ba9312ac35f06dd0adb5508a350e7839ce15",
"triggerType" : "PUSH"
}, {
"hash" : "a14aef0f6ad3723ab050baf53b613fbb014e3cf9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a14aef0f6ad3723ab050baf53b613fbb014e3cf9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3997ba9312ac35f06dd0adb5508a350e7839ce15 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17419)
* a14aef0f6ad3723ab050baf53b613fbb014e3cf9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metadata): key RLI and SI write stats by file group, not file id [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20188:
URL: https://github.com/apache/hudi/pull/20188#issuecomment-5946668060
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/20188?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `43.75000%` with `9 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 80.46%. Comparing base ([`4e08176`](https://app.codecov.io/gh/apache/hudi/commit/4e0817680ea8b2f54bf03ecd32e4048c904a5df5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3997ba9`](https://app.codecov.io/gh/apache/hudi/commit/3997ba9312ac35f06dd0adb5508a350e7839ce15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/20188?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/20188?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/20188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #20188 +/- ##
============================================
- Coverage 80.46% 80.46% -0.01%
+ Complexity 34942 34935 -7
============================================
Files 2549 2549
Lines 143053 143055 +2
Branches 17391 17391
============================================
- Hits 115111 115105 -6
- Misses 20039 20048 +9
+ Partials 7903 7902 -1
```
| [Components](https://app.codecov.io/gh/apache/hudi/pull/20188/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hudi-common](https://app.codecov.io/gh/apache/hudi/pull/20188/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.96% <ø> (ø)` | |
| [hudi-client](https://app.codecov.io/gh/apache/hudi/pull/20188/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.46% <43.75%> (-0.03%)` | :arrow_down: |
| [hudi-flink](https://app.codecov.io/gh/apache/hudi/pull/20188/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.97% <ø> (ø)` | |
| [hudi-spark-datasource](https://app.codecov.io/gh/apache/hudi/pull/20188/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.85% <ø> (ø)` | |
| [hudi-utilities](https://app.codecov.io/gh/apache/hudi/pull/20188/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.14% <ø> (ø)` | |
| [hudi-cli](https://app.codecov.io/gh/apache/hudi/pull/20188/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.78% <ø> (ø)` | |
| [hudi-hadoop](https://app.codecov.io/gh/apache/hudi/pull/20188/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.98% <ø> (ø)` | |
| [hudi-sync](https://app.codecov.io/gh/apache/hudi/pull/20188/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.25% <ø> (ø)` | |
| [hudi-io](https://app.codecov.io/gh/apache/hudi/pull/20188/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.40% <ø> (ø)` | |
| [hudi-timeline-service](https://app.codecov.io/gh/apache/hudi/pull/20188/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.06% <ø> (ø)` | |
| [hudi-cloud](https://app.codecov.io/gh/apache/hudi/pull/20188/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | |
| [hudi-kafka-connect](https://app.codecov.io/gh/apache/hudi/pull/20188/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.96% <ø> (ø)` | |
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/20188/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/20188/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.98% <43.75%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/20188?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/metadata/index/record/BaseRecordIndexer.java](https://app.codecov.io/gh/apache/hudi/pull/20188?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2Findex%2Frecord%2FBaseRecordIndexer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL2luZGV4L3JlY29yZC9CYXNlUmVjb3JkSW5kZXhlci5qYXZh) | `83.03% <100.00%> (+0.06%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/20188?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.18% <0.00%> (-4.18%)` | :arrow_down: |
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metadata): key RLI and SI write stats by file group, not file id [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #20188:
URL: https://github.com/apache/hudi/pull/20188#issuecomment-5946792459
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3997ba9312ac35f06dd0adb5508a350e7839ce15",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17419",
"triggerID" : "3997ba9312ac35f06dd0adb5508a350e7839ce15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3997ba9312ac35f06dd0adb5508a350e7839ce15 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17419)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metadata): key RLI and SI write stats by file group, not file id [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #20188:
URL: https://github.com/apache/hudi/pull/20188#issuecomment-5946549511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3997ba9312ac35f06dd0adb5508a350e7839ce15",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3997ba9312ac35f06dd0adb5508a350e7839ce15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3997ba9312ac35f06dd0adb5508a350e7839ce15 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metadata): key RLI and SI write stats by file group, not file id [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #20188:
URL: https://github.com/apache/hudi/pull/20188#issuecomment-5947860914
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3997ba9312ac35f06dd0adb5508a350e7839ce15",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17419",
"triggerID" : "3997ba9312ac35f06dd0adb5508a350e7839ce15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3997ba9312ac35f06dd0adb5508a350e7839ce15 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=17419)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org