[jira] Updated: (HARMONY-293) reduce duplication in module ant files

["Mark Hindess (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/HARMONY-293?page=all ]

Mark Hindess updated HARMONY-293:
---------------------------------

    Attachment: 01.ant.file.refactor.sh
                02.ant.file.refactor.diff

Tentative proposal for refactoring.  (Note: this incorporates the minor fix from HARMONY-279 since I wanted to test the tests.)

The patch creates a common module.xml build file that all the modules should import.  Specific module build.xml files can then override only the minimal amount of the common build file thus making the differences much more transparent.  Taking the archive and luni example again, the archive build.xml file doesn't override anything and becomes:

  <project name="Build" default="build" basedir="..">
    <description>Build for archive component</description>
    <import file="${basedir}/../../make/module.xml" />
  </project>

while the luni build.xml file becomes:

  <project name="Build" default="build" basedir="..">
    <description>Build for luni component</description>
    <import file="${basedir}/../../make/module.xml" />
    <target name="run.tests">
      <run-tests>
        <!-- Required by various tests that set security manager etc -->
        <jvmarg value="-Djava.security.policy=../../../../support/src/test/resources/config/testing.policy" />
        <!-- Required for running the java.net unit tests -->
        <jvmarg value="-Dtest.ini.file=../../../../src/test/resources/config/localhosttest.ini" />
      </run-tests>
    </target>
  </project>

This makes it quite clear that the difference is only that two additional arguments are passed to the jvm used to run the tests.


> reduce duplication in module ant files
> --------------------------------------
>
>          Key: HARMONY-293
>          URL: http://issues.apache.org/jira/browse/HARMONY-293
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Minor
>  Attachments: 01.ant.file.refactor.sh, 02.ant.file.refactor.diff
>
> At the moment it is very difficult to see the differences between the way different modules are built.
> For instance, one might try to assess the differences between the build process of archive and luni by reading the recursive diff of modules/archive/make and modules/luni/make.  The diff contains many trivial differences (e.g. search and replace archive with luni) that make it difficult to see what the really important differences are.  The common structure should be factored out to a common build file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira