[GitHub] [incubator-openwhisk] dubee commented on a change in pull request #4459: Close the consumer when WakeupExcpetion happened

[GitBox <gi...@apache.org>]

dubee commented on a change in pull request #4459: Close the consumer when WakeupExcpetion happened
URL: https://github.com/apache/incubator-openwhisk/pull/4459#discussion_r286651024
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/connector/kafka/KafkaConsumerConnector.scala
 ##########
 @@ -132,6 +132,11 @@ class KafkaConsumerConnector(
         } else {
           throw e
         }
+      case e: WakeupException =>
+        logging.info(this, s"WakeupException happened when do commit action for topic ${topic}")
+        close()
+        recreateConsumer()
 
 Review comment:
   `wakeup()` is called by the `peak()` method above. Wouldn't recreating the consumer here result in issues when we call `wakeup()` from the `peak()` method? Ie, we'd recreate the consumer here while `peak()` is still trying to do work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services