You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 21:15:45 UTC

[PR] [ISSUE-3791][test] Deepen MetricsBackendTypeTest with custom defaults and whitespace-case normalisation [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3791:
URL: https://github.com/apache/rocketmq-dashboard/pull/3791

   ### Motivation
   
   The existing `MetricsBackendTypeTest` resolves every provider type, defaults unknown values and checks the query paths of the differentiated backends, but the `CUSTOM` backend contract and further normalisation forms of `fromProviderType` were untested.
   
   ### Changes
   
   - `shouldExposeCustomBackendDefaults`: `CUSTOM` keeps the canonical `Custom` provider type and the standard Prometheus query paths.
   - `shouldNormalizeWhitespaceAndMixedCaseBeforeResolving`: surrounding whitespace, underscores and mixed case (`cortex`, `thanos`, `arms`, `Custom`, `victoria_metrics`) all resolve to their canonical backend.
   
   ### Verification
   
   ```
   mvn -B test -Dtest=MetricsBackendTypeTest
   [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
   [INFO] BUILD SUCCESS
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE-3791][test] Deepen MetricsBackendTypeTest with custom defaults and whitespace-case normalisation [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3791: [ISSUE-3791][test] Deepen MetricsBackendTypeTest with custom defaults and whitespace-case normalisation
URL: https://github.com/apache/rocketmq-dashboard/pull/3791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org