[GitHub] [arrow] raulcd commented on a diff in pull request #13385: ARROW-16521 [C++][R] Configure curl timeout policy for S3

[GitBox <gi...@apache.org>]

raulcd commented on code in PR #13385:
URL: https://github.com/apache/arrow/pull/13385#discussion_r898932660


##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -701,6 +701,17 @@ class ClientBuilder {
     if (!options_.region.empty()) {
       client_config_.region = ToAwsString(options_.region);
     }
+    if (options_.request_timeout_ms != -1) {
+      client_config_.requestTimeoutMs = options_.request_timeout_ms;
+    }
+    if (options_.connect_timeout_ms != -1) {
+      client_config_.connectTimeoutMs = options_.connect_timeout_ms;
+    }
+    if (!options_.region.empty()) {

Review Comment:
   I think this is already set on line 701



##########
python/pyarrow/_s3fs.pyx:
##########
@@ -156,7 +156,7 @@ cdef class S3FileSystem(FileSystem):
         CS3FileSystem* s3fs
 
     def __init__(self, *, access_key=None, secret_key=None, session_token=None,
-                 bint anonymous=False, region=None, scheme=None,
+                 bint anonymous=False, region=None, request_timeout_ms = None, connect_timeout_ms = None, scheme=None,

Review Comment:
   this will fail linting:
   ```suggestion
                    bint anonymous=False, region=None, request_timeout_ms=None, connect_timeout_ms=None, scheme=None,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org