You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/11/02 15:07:41 UTC
[GitHub] [incubator-mxnet] bartekkuncer opened a new pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
bartekkuncer opened a new pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719
## Description ##
This PR aims to unify all names used to refer to oneDNN library in logs and docs to oneDNN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-957980498
@mxnet-bot run ci [centos-cpu, centos-gpu,miscellaneous]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#discussion_r742629983
##########
File path: docs/static_site/src/pages/api/faq/large_tensor_support.md
##########
@@ -141,9 +141,9 @@ Backward pass is partially supported and not completely tested, so it is conside
Not supported:
-* GPU and ONEDNN.
+* GPU and oneDNN.
* Windows, ARM or any operating system other than Ubuntu
-* Any permutation of MXNet wheel that contains ONEDNN.
+* Any permutation of MXNet wheel that contains oneDNN.
Review comment:
I will create JIRA for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-973853202
Jenkins CI successfully triggered : [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-971457441
@mxnet-bot run ci [centos-cpu, centos-gpu, unix-cpu, windows-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-972709828
@mxnet-bot run ci [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-973853120
@mxnet-bot run ci [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#discussion_r742617292
##########
File path: ci/jenkins/Jenkins_steps.groovy
##########
@@ -174,7 +174,7 @@ def compile_unix_mkl_cpu(lib_name) {
}
def compile_unix_onednn_cpu(lib_name) {
- return ['CPU: ONEDNN': {
+ return ['CPU: oneDNN': {
Review comment:
please double check if "oneDNN" here works properly
##########
File path: NEWS.md
##########
@@ -26,7 +26,7 @@ MXNet Change Log
* [CUDA Graphs](#cuda-graphs)
* [CUDA 11 Support](#cuda-11-support)
* [TensorRT](#tensorrt)
- * [OneDNN](#onednn)
+ * [oneDNN](#onednn)
Review comment:
I am not sure if "Change Log" should be changed. I suppose not
##########
File path: docs/static_site/src/pages/api/faq/large_tensor_support.md
##########
@@ -141,9 +141,9 @@ Backward pass is partially supported and not completely tested, so it is conside
Not supported:
-* GPU and ONEDNN.
+* GPU and oneDNN.
* Windows, ARM or any operating system other than Ubuntu
-* Any permutation of MXNet wheel that contains ONEDNN.
+* Any permutation of MXNet wheel that contains oneDNN.
Review comment:
seems not to be valid. Please check and fix in separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-958763143
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-958763228
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-971457517
Jenkins CI successfully triggered : [centos-gpu, centos-cpu, windows-cpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-958763143
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-957980498
@mxnet-bot run ci [centos-cpu, centos-gpu,miscellaneous]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#discussion_r752321675
##########
File path: src/operator/nn/dnnl/dnnl_base-inl.h
##########
@@ -258,7 +258,7 @@ static inline int get_mxnet_type(dnnl_data_type_t dtype) {
case dnnl::memory::data_type::u8:
return mshadow::kUint8;
default:
- LOG(FATAL) << "unknown DNNL type";
+ LOG(FATAL) << "unknown oneDNN type";
Review comment:
```suggestion
LOG(FATAL) << "unknown oneDNN data type";
```
##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -2066,7 +2066,7 @@ def test_rnn_dim_check():
@use_np
-@pytest.mark.skip(reason='runs without DNNL, wtih is not default behavior')
+@pytest.mark.skip(reason='runs without oneDNN, with is not default behavior')
Review comment:
```suggestion
@pytest.mark.skip(reason='runs without oneDNN, which is not default behavior')
```
I am not sure what doesn't mean. This test pass when run in mxnet-native version?
##########
File path: src/operator/nn/dnnl/dnnl_fully_connected.cc
##########
@@ -65,7 +65,7 @@ dnnl::inner_product_forward::primitive_desc GetFCFwdImpl(const DNNLFCFullParam&
return dnnl::inner_product_forward::primitive_desc(desc, attr, engine);
} catch (dnnl::error& e) {
if (e.status == dnnl_unimplemented && full_param.dnnl_param.quantized) {
- LOG(ERROR) << "AVX512-BW support or DNNL v0.18 is required for INT8 fully_connected.";
+ LOG(ERROR) << "AVX512-BW support or oneDNN v0.18 is required for INT8 fully_connected.";
Review comment:
```suggestion
LOG(ERROR) << "AVX512-BW support or oneDNN v0.18 or later is required for INT8 fully_connected.";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-958763228
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-958763143
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-958763143
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#discussion_r742629659
##########
File path: ci/jenkins/Jenkins_steps.groovy
##########
@@ -174,7 +174,7 @@ def compile_unix_mkl_cpu(lib_name) {
}
def compile_unix_onednn_cpu(lib_name) {
- return ['CPU: ONEDNN': {
+ return ['CPU: oneDNN': {
Review comment:
Works properly, this just changes name of build/test scenario visible on Jenkins e.g. https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-20719/3/pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#discussion_r741935766
##########
File path: tools/dependencies/README.md
##########
@@ -52,12 +52,12 @@ MXNet is built on top of many dependencies. Managing these dependencies could be
## Overview
-The dependencies could be categorized by several groups: BLAS libraries, CPU-based performance boost library, i.e. ONEDNN and GPU-based performance boosting library including CUDA, cuDNN, NCCL. and others including OpenCV, Numpy, S3-related, PS-lite dependencies. The list below shows all the dependencies and their version. Except for CUDA, cuDNN, NCCL which the user is required to install on their environments, we statically link those dependencies into libmxnet.so when we build PyPi package. By doing this, the user can take advantage of these dependencies without being worry about it.
+The dependencies could be categorized by several groups: BLAS libraries, CPU-based performance boost library, i.e. oneDNN and GPU-based performance boosting library including CUDA, cuDNN, NCCL. and others including OpenCV, Numpy, S3-related, PS-lite dependencies. The list below shows all the dependencies and their version. Except for CUDA, cuDNN, NCCL which the user is required to install on their environments, we statically link those dependencies into libmxnet.so when we build PyPi package. By doing this, the user can take advantage of these dependencies without being worry about it.
| Dependencies | MXNet Version |
| :------------: |:-------------:|
|OpenBLAS| 0.3.9 |
-|ONEDNN| 2.0 |
+|oneDNN| 2.0 |
Review comment:
is this dependency still valid? as oneDNN is included in source directory ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#discussion_r742626786
##########
File path: tools/dependencies/README.md
##########
@@ -52,12 +52,12 @@ MXNet is built on top of many dependencies. Managing these dependencies could be
## Overview
-The dependencies could be categorized by several groups: BLAS libraries, CPU-based performance boost library, i.e. ONEDNN and GPU-based performance boosting library including CUDA, cuDNN, NCCL. and others including OpenCV, Numpy, S3-related, PS-lite dependencies. The list below shows all the dependencies and their version. Except for CUDA, cuDNN, NCCL which the user is required to install on their environments, we statically link those dependencies into libmxnet.so when we build PyPi package. By doing this, the user can take advantage of these dependencies without being worry about it.
+The dependencies could be categorized by several groups: BLAS libraries, CPU-based performance boost library, i.e. oneDNN and GPU-based performance boosting library including CUDA, cuDNN, NCCL. and others including OpenCV, Numpy, S3-related, PS-lite dependencies. The list below shows all the dependencies and their version. Except for CUDA, cuDNN, NCCL which the user is required to install on their environments, we statically link those dependencies into libmxnet.so when we build PyPi package. By doing this, the user can take advantage of these dependencies without being worry about it.
| Dependencies | MXNet Version |
| :------------: |:-------------:|
|OpenBLAS| 0.3.9 |
-|ONEDNN| 2.0 |
+|oneDNN| 2.0 |
Review comment:
Good catch, will update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-957779525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#discussion_r741935766
##########
File path: tools/dependencies/README.md
##########
@@ -52,12 +52,12 @@ MXNet is built on top of many dependencies. Managing these dependencies could be
## Overview
-The dependencies could be categorized by several groups: BLAS libraries, CPU-based performance boost library, i.e. ONEDNN and GPU-based performance boosting library including CUDA, cuDNN, NCCL. and others including OpenCV, Numpy, S3-related, PS-lite dependencies. The list below shows all the dependencies and their version. Except for CUDA, cuDNN, NCCL which the user is required to install on their environments, we statically link those dependencies into libmxnet.so when we build PyPi package. By doing this, the user can take advantage of these dependencies without being worry about it.
+The dependencies could be categorized by several groups: BLAS libraries, CPU-based performance boost library, i.e. oneDNN and GPU-based performance boosting library including CUDA, cuDNN, NCCL. and others including OpenCV, Numpy, S3-related, PS-lite dependencies. The list below shows all the dependencies and their version. Except for CUDA, cuDNN, NCCL which the user is required to install on their environments, we statically link those dependencies into libmxnet.so when we build PyPi package. By doing this, the user can take advantage of these dependencies without being worry about it.
| Dependencies | MXNet Version |
| :------------: |:-------------:|
|OpenBLAS| 0.3.9 |
-|ONEDNN| 2.0 |
+|oneDNN| 2.0 |
Review comment:
is this dependency still valid? as oneDNN is included in source directory ?
##########
File path: tools/dependencies/README.md
##########
@@ -52,12 +52,12 @@ MXNet is built on top of many dependencies. Managing these dependencies could be
## Overview
-The dependencies could be categorized by several groups: BLAS libraries, CPU-based performance boost library, i.e. ONEDNN and GPU-based performance boosting library including CUDA, cuDNN, NCCL. and others including OpenCV, Numpy, S3-related, PS-lite dependencies. The list below shows all the dependencies and their version. Except for CUDA, cuDNN, NCCL which the user is required to install on their environments, we statically link those dependencies into libmxnet.so when we build PyPi package. By doing this, the user can take advantage of these dependencies without being worry about it.
+The dependencies could be categorized by several groups: BLAS libraries, CPU-based performance boost library, i.e. oneDNN and GPU-based performance boosting library including CUDA, cuDNN, NCCL. and others including OpenCV, Numpy, S3-related, PS-lite dependencies. The list below shows all the dependencies and their version. Except for CUDA, cuDNN, NCCL which the user is required to install on their environments, we statically link those dependencies into libmxnet.so when we build PyPi package. By doing this, the user can take advantage of these dependencies without being worry about it.
| Dependencies | MXNet Version |
| :------------: |:-------------:|
|OpenBLAS| 0.3.9 |
-|ONEDNN| 2.0 |
+|oneDNN| 2.0 |
Review comment:
is this dependency still valid? as oneDNN is included in source directory ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-957779525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-958763228
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-957779525
Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, windows-cpu, sanity, miscellaneous, unix-cpu, windows-gpu, centos-gpu, clang, centos-cpu, unix-gpu, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#discussion_r741935766
##########
File path: tools/dependencies/README.md
##########
@@ -52,12 +52,12 @@ MXNet is built on top of many dependencies. Managing these dependencies could be
## Overview
-The dependencies could be categorized by several groups: BLAS libraries, CPU-based performance boost library, i.e. ONEDNN and GPU-based performance boosting library including CUDA, cuDNN, NCCL. and others including OpenCV, Numpy, S3-related, PS-lite dependencies. The list below shows all the dependencies and their version. Except for CUDA, cuDNN, NCCL which the user is required to install on their environments, we statically link those dependencies into libmxnet.so when we build PyPi package. By doing this, the user can take advantage of these dependencies without being worry about it.
+The dependencies could be categorized by several groups: BLAS libraries, CPU-based performance boost library, i.e. oneDNN and GPU-based performance boosting library including CUDA, cuDNN, NCCL. and others including OpenCV, Numpy, S3-related, PS-lite dependencies. The list below shows all the dependencies and their version. Except for CUDA, cuDNN, NCCL which the user is required to install on their environments, we statically link those dependencies into libmxnet.so when we build PyPi package. By doing this, the user can take advantage of these dependencies without being worry about it.
| Dependencies | MXNet Version |
| :------------: |:-------------:|
|OpenBLAS| 0.3.9 |
-|ONEDNN| 2.0 |
+|oneDNN| 2.0 |
Review comment:
is this dependency still valid? as oneDNN is included in source directory ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-973135323
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-972709913
Jenkins CI successfully triggered : [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-973135212
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych merged pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bgawrych merged pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#issuecomment-958763228
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20719: Unify all names used to refer to oneDNN library in logs and docs to oneDNN
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#discussion_r742628156
##########
File path: NEWS.md
##########
@@ -26,7 +26,7 @@ MXNet Change Log
* [CUDA Graphs](#cuda-graphs)
* [CUDA 11 Support](#cuda-11-support)
* [TensorRT](#tensorrt)
- * [OneDNN](#onednn)
+ * [oneDNN](#onednn)
Review comment:
As I am not changing any information I believe this small change is fine. @szha Should I leave NEWS.md file without any changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org