You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/02/03 20:11:25 UTC

Re: Review Request 30468: Failing to register hosts on Centos5

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30468/
-----------------------------------------------------------

(Updated Feb. 3, 2015, 7:11 p.m.)


Review request for Ambari, Dmytro Sen, Jayush Luniya, and Mahadev Konar.


Changes
-------

Fixed return value inconsistencies.
Fixed unit tests.


Bugs: AMBARI-9341
    https://issues.apache.org/jira/browse/AMBARI-9341


Repository: ambari


Description
-------

sys.exit() should never be braced in a try/except. The behavior changed in Python 2.5. See the doc.


Diffs (updated)
-----

  ambari-server/src/main/python/setupAgent.py b2c2d255278d803a7fde71056500688ef85a7d68 
  ambari-server/src/test/python/TestSetupAgent.py 249ce0b15828f5508f072573dae26158b1b0470b 

Diff: https://reviews.apache.org/r/30468/diff/


Testing
-------

Bootstrap in a local CentOS 5 cluster.


Thanks,

Florian Barca

Re: Review Request 30468: Failing to register hosts on Centos5

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30468/#review70840
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On Feb. 3, 2015, 10:38 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30468/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 10:38 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Mahadev Konar.
> 
> 
> Bugs: AMBARI-9341
>     https://issues.apache.org/jira/browse/AMBARI-9341
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> sys.exit() should never be braced in a try/except. The behavior changed in Python 2.5. See the doc.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/setupAgent.py b2c2d255278d803a7fde71056500688ef85a7d68 
>   ambari-server/src/test/python/TestSetupAgent.py 249ce0b15828f5508f072573dae26158b1b0470b 
> 
> Diff: https://reviews.apache.org/r/30468/diff/
> 
> 
> Testing
> -------
> 
> Bootstrap in a local CentOS 5 cluster.
> 
> 
> Thanks,
> 
> Florian Barca
> 
>

Re: Review Request 30468: Failing to register hosts on Centos5

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30468/
-----------------------------------------------------------

(Updated Feb. 3, 2015, 10:38 p.m.)


Review request for Ambari, Dmytro Sen, Jayush Luniya, and Mahadev Konar.


Bugs: AMBARI-9341
    https://issues.apache.org/jira/browse/AMBARI-9341


Repository: ambari


Description
-------

sys.exit() should never be braced in a try/except. The behavior changed in Python 2.5. See the doc.


Diffs (updated)
-----

  ambari-server/src/main/python/setupAgent.py b2c2d255278d803a7fde71056500688ef85a7d68 
  ambari-server/src/test/python/TestSetupAgent.py 249ce0b15828f5508f072573dae26158b1b0470b 

Diff: https://reviews.apache.org/r/30468/diff/


Testing
-------

Bootstrap in a local CentOS 5 cluster.


Thanks,

Florian Barca

Re: Review Request 30468: Failing to register hosts on Centos5

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30468/#review70829
-----------------------------------------------------------



ambari-server/src/test/python/TestSetupAgent.py
<https://reviews.apache.org/r/30468/#comment116271>

    I see following unit test failure with the patch.
    
    Failed tests:
    ERROR: test_runAgent (TestSetupAgent.TestSetupAgent)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/Users/jluniya/clean/trunk/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
        return func(*args, **keywargs)
      File "/Users/jluniya/clean/trunk/ambari/ambari-server/src/test/python/TestSetupAgent.py", line 66, in test_runAgent
        cmdStr = str(call_mock.call_args_list[0][0])
    IndexError: list index out of range
    
    ----------------------------------------------------------------------


- Jayush Luniya


On Feb. 3, 2015, 7:11 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30468/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 7:11 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Mahadev Konar.
> 
> 
> Bugs: AMBARI-9341
>     https://issues.apache.org/jira/browse/AMBARI-9341
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> sys.exit() should never be braced in a try/except. The behavior changed in Python 2.5. See the doc.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/setupAgent.py b2c2d255278d803a7fde71056500688ef85a7d68 
>   ambari-server/src/test/python/TestSetupAgent.py 249ce0b15828f5508f072573dae26158b1b0470b 
> 
> Diff: https://reviews.apache.org/r/30468/diff/
> 
> 
> Testing
> -------
> 
> Bootstrap in a local CentOS 5 cluster.
> 
> 
> Thanks,
> 
> Florian Barca
> 
>