You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Matthias Germann (JIRA)" <ji...@apache.org> on 2007/07/24 11:58:31 UTC

[jira] Created: (CXF-825) WSS4JOutInterceptor does not work without "user" Property

WSS4JOutInterceptor does not work without "user" Property
---------------------------------------------------------

                 Key: CXF-825
                 URL: https://issues.apache.org/jira/browse/CXF-825
             Project: CXF
          Issue Type: Bug
          Components: WS-* Components
    Affects Versions: 2.0
            Reporter: Matthias Germann


The WSS4JOutInterceptor does not work if the WSHandlerConstants.USER configuration property is not set. But there exist some actions which do not require this property (i.e. SAMLTokenUnsigned). Therefore, this property should not be mandatory.

The Interceptor fails as follows:

A NullPointerException occurs if the property is not set:
java.lang.NullPointerException
	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:119)
	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:42)

A SoapFaultoccurs if the property is set to an empty string:
org.apache.cxf.binding.soap.SoapFault: NO_USERNAME
	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:126)
	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:42)



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CXF-825) WSS4JOutInterceptor does not work without "user" Property

Posted by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colm O hEigeartaigh updated CXF-825:
------------------------------------

    Attachment: cxf_saml.patch

> WSS4JOutInterceptor does not work without "user" Property
> ---------------------------------------------------------
>
>                 Key: CXF-825
>                 URL: https://issues.apache.org/jira/browse/CXF-825
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.0
>            Reporter: Matthias Germann
>         Attachments: cxf_saml.patch
>
>
> The WSS4JOutInterceptor does not work if the WSHandlerConstants.USER configuration property is not set. But there exist some actions which do not require this property (i.e. SAMLTokenUnsigned). Therefore, this property should not be mandatory.
> The Interceptor fails as follows:
> A NullPointerException occurs if the property is not set:
> java.lang.NullPointerException
> 	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:119)
> 	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:42)
> A SoapFaultoccurs if the property is set to an empty string:
> org.apache.cxf.binding.soap.SoapFault: NO_USERNAME
> 	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:126)
> 	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:42)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-825) WSS4JOutInterceptor does not work without "user" Property

Posted by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521852 ] 

Colm O hEigeartaigh commented on CXF-825:
-----------------------------------------


The problem here is down to a missing set of brackets in the if statement in WSS4JOutInterceptor.

The logic of the if statement on line 119 of WSS4JOutInterceptor currently reads "if (a && b || c)" whereas
it should read "if (a && (b || c))".

I have supplied a patch attached to this jira item + will ask the cxf-dev list to commit it.

> WSS4JOutInterceptor does not work without "user" Property
> ---------------------------------------------------------
>
>                 Key: CXF-825
>                 URL: https://issues.apache.org/jira/browse/CXF-825
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.0
>            Reporter: Matthias Germann
>
> The WSS4JOutInterceptor does not work if the WSHandlerConstants.USER configuration property is not set. But there exist some actions which do not require this property (i.e. SAMLTokenUnsigned). Therefore, this property should not be mandatory.
> The Interceptor fails as follows:
> A NullPointerException occurs if the property is not set:
> java.lang.NullPointerException
> 	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:119)
> 	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:42)
> A SoapFaultoccurs if the property is set to an empty string:
> org.apache.cxf.binding.soap.SoapFault: NO_USERNAME
> 	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:126)
> 	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:42)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CXF-825) WSS4JOutInterceptor does not work without "user" Property

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-825.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.2
         Assignee: Ulhas Bhole


Patch was applied in Aug, 2007

> WSS4JOutInterceptor does not work without "user" Property
> ---------------------------------------------------------
>
>                 Key: CXF-825
>                 URL: https://issues.apache.org/jira/browse/CXF-825
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.0
>            Reporter: Matthias Germann
>            Assignee: Ulhas Bhole
>             Fix For: 2.0.2
>
>         Attachments: cxf_saml.patch
>
>
> The WSS4JOutInterceptor does not work if the WSHandlerConstants.USER configuration property is not set. But there exist some actions which do not require this property (i.e. SAMLTokenUnsigned). Therefore, this property should not be mandatory.
> The Interceptor fails as follows:
> A NullPointerException occurs if the property is not set:
> java.lang.NullPointerException
> 	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:119)
> 	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:42)
> A SoapFaultoccurs if the property is set to an empty string:
> org.apache.cxf.binding.soap.SoapFault: NO_USERNAME
> 	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:126)
> 	at org.apache.cxf.ws.security.wss4j.WSS4JOutInterceptor.handleMessage(WSS4JOutInterceptor.java:42)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.