[jira] [Commented] (CASSANDRA-13965) SecondaryIndexManagerTest.assert[Not]MarkedAsBuilt produces flaky tests

["Andrés de la Peña (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-13965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209535#comment-16209535 ] 

Andrés de la Peña commented on CASSANDRA-13965:
-----------------------------------------------

[Here|https://github.com/apache/cassandra/compare/trunk...adelapena:13965-trunk] is a patch modifying the methods to only verify the presence/absence in {{system.IndexInfo}} table of the index of interest.

> SecondaryIndexManagerTest.assert[Not]MarkedAsBuilt produces flaky tests
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-13965
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13965
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Secondary Indexes, Testing
>            Reporter: Andrés de la Peña
>            Assignee: Andrés de la Peña
>            Priority: Minor
>             Fix For: 4.x
>
>
> The methods [{{SecondaryIndexManagerTest.assertMarkedAsBuilt}}|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/index/SecondaryIndexManagerTest.java#L554-L557] and [{{SecondaryIndexManagerTest.assertNotMarkedAsBuilt}}|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/index/SecondaryIndexManagerTest.java#L559-L562] produce occasional test failures. 
> These methods assume that there aren't any other indexes in the {{system.IndexInfo}} table than those created by the calling test. However, it is possible to find indexes built for other tests (not only {{SecondaryIndexManagerTest}}) that rely on {{CQLTester.afterTest}} to cleanup to drop their created indexes, because this method is asynchronous. So, it is possible to reach the {{SecondaryIndexManagerTest.assert(Not)MarkedAsBuilt}} calls before the indexes created by the previous test have been cleaned up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org