You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/21 08:15:21 UTC

[GitHub] [incubator-superset] kkucharc commented on a change in pull request #10942: fix: setting specific exceptions common/query_context.py

kkucharc commented on a change in pull request #10942:
URL: https://github.com/apache/incubator-superset/pull/10942#discussion_r491861987



##########
File path: superset/common/query_context.py
##########
@@ -265,7 +265,7 @@ def get_df_payload(  # pylint: disable=too-many-locals,too-many-statements
             except QueryObjectValidationError as ex:
                 error_message = str(ex)
                 status = utils.QueryStatus.FAILED
-            except Exception as ex:  # pylint: disable=broad-except
+            except KeyError as ex:

Review comment:
       Sure, no problem - I'll bring it back. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org