[GitHub] [beam] msbukal commented on a diff in pull request #17598: [BEAM-14451] Support export to BigQuery in FhirIO.Export

[GitBox <gi...@apache.org>]

msbukal commented on code in PR #17598:
URL: https://github.com/apache/beam/pull/17598#discussion_r876136158


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIOTest.java:
##########
@@ -146,4 +151,17 @@ public void test_FhirIO_failedPatientEverything() {
     PAssert.that(everythingResult.getPatientCompartments()).empty();
     pipeline.run();
   }
+
+  @Test
+  public void test_FhirIO_Export_invalidUri() {
+    final String invalidUri = "someInvalidUri";
+    pipeline
+        .apply(Create.of(Arrays.asList("resource1", "resource2")))

Review Comment:
   What's the point of this line? Also just call FhirIO.exportResources(...) same as the other tests



##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java:
##########
@@ -194,11 +193,11 @@
  * FhirIO.Write.Result writeResult =
  *     output.apply("Import FHIR Resources", FhirIO.executeBundles(options.getNewFhirStore()));
  *
- * // Export FHIR resources to Google Cloud Storage.
+ * // Export FHIR resources to Google Cloud Storage or BigQuery.

Review Comment:
   Can you also update the comment on line 135 (just add BigQuery)



##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java:
##########
@@ -1518,6 +1508,7 @@ private int parseBundleStatus(String status) {
 
   /**
    * Export FHIR resources from a FHIR store to new line delimited json files on GCS or BigQuery.
+   * Output PCollection should contain the URI where the FHIR store was exported to.

Review Comment:
   should contain -> contains



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org