You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/09/17 12:03:48 UTC
[GitHub] [nifi-minifi-cpp] adam-markovics opened a new pull request #1175: MINIFICPP-1646 - Exclude CLion generated build directories from flake8 scan
adam-markovics opened a new pull request #1175:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1175
Such as cmake-build-debug, cmake-build-release, cmake-build-relwithdebinfo.
This is to get a clean output when running flake8 locally.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1175: MINIFICPP-1646 - Exclude CLion generated build directories from flake8 scan
Posted by GitBox <gi...@apache.org>.
fgerlits commented on a change in pull request #1175:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1175#discussion_r712025205
##########
File path: run_flake8.sh
##########
@@ -19,4 +19,4 @@
set -euo pipefail
directory=${1:-.}
-flake8 --exclude thirdparty,build --builtins log,REL_SUCCESS,REL_FAILURE,raw_input --ignore E501,W503 --per-file-ignores="steps.py:F811" "${directory}"
+flake8 --exclude thirdparty,build,cmake-build-debug,cmake-build-release,cmake-build-relwithdebinfo --builtins log,REL_SUCCESS,REL_FAILURE,raw_input --ignore E501,W503 --per-file-ignores="steps.py:F811" "${directory}"
Review comment:
I would prefer `cmake-build-*`, as there are other options as well, e.g. cmake-build-debug-coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1175: MINIFICPP-1646 - Exclude CLion generated build directories from flake8 scan
Posted by GitBox <gi...@apache.org>.
adam-markovics commented on a change in pull request #1175:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1175#discussion_r712034564
##########
File path: run_flake8.sh
##########
@@ -19,4 +19,4 @@
set -euo pipefail
directory=${1:-.}
-flake8 --exclude thirdparty,build --builtins log,REL_SUCCESS,REL_FAILURE,raw_input --ignore E501,W503 --per-file-ignores="steps.py:F811" "${directory}"
+flake8 --exclude thirdparty,build,cmake-build-debug,cmake-build-release,cmake-build-relwithdebinfo --builtins log,REL_SUCCESS,REL_FAILURE,raw_input --ignore E501,W503 --per-file-ignores="steps.py:F811" "${directory}"
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1175: MINIFICPP-1646 - Exclude CLion generated build directories from flake8 scan
Posted by GitBox <gi...@apache.org>.
szaszm closed pull request #1175:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org