You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ojb-dev@db.apache.org by Antonio Gallardo <ag...@agssa.net> on 2005/03/09 07:32:44 UTC
jars that can be easily updated
Hi:
I already make a rebuild + test the databases and getting the same results
with this jar updates:
antlr to 2.7.5
commons-beanutils to 1.7
commons-dbcp to 1.2.1
commons-pool to 1.2
commons-logging to 1.0.4
log4j to 1.2.9
I think we can safely update all of them.
Best Regards,
Antonio Gallardo
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: jars that can be easily updated
Posted by Martin Kalén <mk...@apache.org>.
Thomas Dudziak wrote:
>>My OQL-grammar knowledge is not good enough to have a stab at antlr,
>>so I leave this one to other takers. :-) (Tom?)
>
> You can simply replace the antlr jar, then run the oql-grammar target
> (don't know exactly the name), and then the ODMG unit tests. If this
> all works as before, then we can update antlr.
I'm in the process of upgrading ANTLR to v2.7.5, seems like minor changes
as far as OJB is concerned. There is a recover-wrapper beeing called on
expressions caught in the parser.
However, I didn't see an ant-target to re-generate the JDO jdoql files
so I added one and generated those as well. Maybe someone can review
this after commit (Brian?).
A bonus of re-running the tests was that I got a stracktrace that
Armin can use to track his Heisenbug... ;-)
http://issues.apache.org/jira/browse/OJB-15
Regards,
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: jars that can be easily updated
Posted by Thomas Dudziak <to...@gmail.com>.
> My OQL-grammar knowledge is not good enough to have a stab at antlr,
> so I leave this one to other takers. :-) (Tom?)
You can simply replace the antlr jar, then run the oql-grammar target
(don't know exactly the name), and then the ODMG unit tests. If this
all works as before, then we can update antlr.
Tom
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: jars that can be easily updated
Posted by Martin Kalén <mk...@apache.org>.
Antonio Gallardo wrote:
> I already make a rebuild + test the databases and getting the same results
> with this jar updates:
>
> antlr to 2.7.5
> commons-beanutils to 1.7
> commons-dbcp to 1.2.1
> commons-pool to 1.2
> commons-logging to 1.0.4
> log4j to 1.2.9
>
> I think we can safely update all of them.
I have now upgraded commons-beanutils, commons-pool and commons-logging
in the 1.0.x branch for a future 1.0.4 maintenance release.
I will have a look at DBCP later.
As stated previously, I think we can skip Log4J as there is no binary
changes between 1.2.8/.9 (only some deprecation/historic support changes).
My OQL-grammar knowledge is not good enough to have a stab at antlr,
so I leave this one to other takers. :-) (Tom?)
Regards,
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: jars that can be easily updated
Posted by Martin Kalén <mk...@apache.org>.
Thomas Dudziak wrote:
>>The antlr JAR will only be used when re-generating OQL grammar with
>>"ant oql" (never used by OJB run-time, only seldom when OQL grammar
>>changes).
>
> Actually that's not true. The Antlr Runtime classes are used whenever
> a OQL expression is evaluated, e.g. in some ODMG tests. That's also
> why this particular change needs a re-generation of the OQL parser
> followed by a retest of at least the ODMG tests.
Thanks for clarifying; that changes what I stated re antlr JAR not
beeing excercised in tests.
>>The DBCP JAR will only be used when selecting DBCP as connection factory
>>in OJB.properties (not used by default for OJB run-time, only when you
>>select DBCP connection factory in OJB.properties).
>>
>>A new testcase should really be added that makes some simple
>>connection-pool checkout/checkin operations for each connection factory
>>implementation.
>
> Nonetheless it is useful to include it with OJB, especially because I
> think it is used somewhere in ojb-blank or in the tutorials.
Absolutely! I'm not at all saying we should throw DBCP out - just that
Antonio's re-testing with a new DBCP JAR is not a validation of that the
new DBCP JAR works with OJB. Simply because there is no test-case
covering DBCP operations (and that I think should be added).
I am a happy user of OJB + DBCP myself. :)
>> > commons-pool to 1.2
>> > commons-beanutils to 1.7
>> > commons-logging to 1.0.4
>>
>>These, together with DBCP, are probably the most important ones for OJB
>>run-time operations and after 1.0.2 release it's a good idea to upgrade.
>
> IMO changes to libraries that are used at runtime requires a rerun of
> the unit tests on all supported databases, so we perhaps should defer
> it to 1.0.3 ?
I agree that all tests for all platforms must be re-run.
I think my "after 1.0.2" and your "defer it to 1.0.3" are compatible
statements. ;-)
Cheers,
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: jars that can be easily updated
Posted by Thomas Dudziak <to...@gmail.com>.
On Fri, 11 Mar 2005 13:15:50 +0100, Martin Kalén <mk...@apache.org> wrote:
> Antonio Gallardo wrote:
> > I already make a rebuild + test the databases and getting the same results
> > with this jar updates:
>
> Thanks for testing, Antonio. Something to look into after Sunday's release.
>
> > antlr to 2.7.5
> > commons-dbcp to 1.2.1
>
> NB: you are not testing antlr and/or DBCP using the standard test suite.
>
> The antlr JAR will only be used when re-generating OQL grammar with
> "ant oql" (never used by OJB run-time, only seldom when OQL grammar
> changes).
Actually that's not true. The Antlr Runtime classes are used whenever
a OQL expression is evaluated, e.g. in some ODMG tests. That's also
why this particular change needs a re-generation of the OQL parser
followed by a retest of at least the ODMG tests.
> The DBCP JAR will only be used when selecting DBCP as connection factory
> in OJB.properties (not used by default for OJB run-time, only when you
> select DBCP connection factory in OJB.properties).
>
> A new testcase should really be added that makes some simple
> connection-pool checkout/checkin operations for each connection factory
> implementation.
Nonetheless it is useful to include it with OJB, especially because I
think it is used somewhere in ojb-blank or in the tutorials.
> > log4j to 1.2.9
>
> This JAR is identical to 1.2.8. Only difference is that some older
> methods are marked as deprecated, so it's not that important to upgrade
> before 1.3.0 is out (old ~= stone ages ;) OJB is not using any of those
> deprecated calls).
>
> > commons-pool to 1.2
> > commons-beanutils to 1.7
> > commons-logging to 1.0.4
>
> These, together with DBCP, are probably the most important ones for OJB
> run-time operations and after 1.0.2 release it's a good idea to upgrade.
IMO changes to libraries that are used at runtime requires a rerun of
the unit tests on all supported databases, so we perhaps should defer
it to 1.0.3 ?
Tom
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: jars that can be easily updated
Posted by Martin Kalén <mk...@apache.org>.
Antonio Gallardo wrote:
> I already make a rebuild + test the databases and getting the same results
> with this jar updates:
Thanks for testing, Antonio. Something to look into after Sunday's release.
> antlr to 2.7.5
> commons-dbcp to 1.2.1
NB: you are not testing antlr and/or DBCP using the standard test suite.
The antlr JAR will only be used when re-generating OQL grammar with
"ant oql" (never used by OJB run-time, only seldom when OQL grammar
changes).
The DBCP JAR will only be used when selecting DBCP as connection factory
in OJB.properties (not used by default for OJB run-time, only when you
select DBCP connection factory in OJB.properties).
A new testcase should really be added that makes some simple
connection-pool checkout/checkin operations for each connection factory
implementation.
> log4j to 1.2.9
This JAR is identical to 1.2.8. Only difference is that some older
methods are marked as deprecated, so it's not that important to upgrade
before 1.3.0 is out (old ~= stone ages ;) OJB is not using any of those
deprecated calls).
> commons-pool to 1.2
> commons-beanutils to 1.7
> commons-logging to 1.0.4
These, together with DBCP, are probably the most important ones for OJB
run-time operations and after 1.0.2 release it's a good idea to upgrade.
Regards,
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org