You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@libcloud.apache.org by "Tomaz Muraus (Resolved) (JIRA)" <ji...@apache.org> on 2011/11/03 15:57:32 UTC
[dev] [jira] [Resolved] (LIBCLOUD-126) Fix balancer_attach_compute_node
caller and indentation
[ https://issues.apache.org/jira/browse/LIBCLOUD-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tomaz Muraus resolved LIBCLOUD-126.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.6.0
Thanks for the patch and spotting this. This patch is actually only a partial fix. Method call inside balancer_attach_compute_node was also missing an argument (balancer).
I have fixed this and also added a test in r1197169 (http://svn.apache.org/viewvc?rev=1197169&view=rev).
Next time when creating a patch also don't forget to follow the guidelines on "contributing" page and use --no-prefix argument when creating a patch using git.
> Fix balancer_attach_compute_node caller and indentation
> -------------------------------------------------------
>
> Key: LIBCLOUD-126
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-126
> Project: Libcloud
> Issue Type: Improvement
> Components: Core
> Reporter: Tim Fletcher
> Priority: Minor
> Fix For: 0.6.0
>
> Attachments: patch.diff
>
>
> The call to Driver.balancer_attach_compute_node in LoadBalancer.attach_compute_node appears to be missing a parameter (itself)
> Also fixes the indentation of Driver.balancer_attach_compute_node to be consistent
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [dev] [jira] [Resolved] (LIBCLOUD-126) Fix balancer_attach_compute_node
caller and indentation
Posted by Tim Fletcher <ma...@tfletcher.com>.
> I have fixed this and also added a test in r1197169 (http://svn.apache.org/viewvc?rev=1197169&view=rev).
Great, thanks Tomaz.
> Next time when creating a patch also don't forget to follow the guidelines on "contributing"
> page and use --no-prefix argument when creating a patch using git.
Sorry, yes. I'll follow the guidelines closely next time.
Cheers,
Tim