You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/26 07:40:11 UTC

[GitHub] [spark] viirya commented on a change in pull request #32348: [SPARK-35230][SQL] Move custom metric classes to proper package

viirya commented on a change in pull request #32348:
URL: https://github.com/apache/spark/pull/32348#discussion_r620045404



##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/metric/CustomMetric.java
##########
@@ -29,23 +29,23 @@
  */
 @Evolving
 public interface CustomMetric {
-    /**
-     * Returns the name of custom metric.
-     */
-    String name();
+  /**

Review comment:
       indentation was wrong. Fixed them together.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org