You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "nicob3y (via GitHub)" <gi...@apache.org> on 2025/12/19 00:10:00 UTC

[PR] UI fixes for table plugins [superset]

nicob3y opened a new pull request, #36753:
URL: https://github.com/apache/superset/pull/36753

   ### SUMMARY
   
   Fixing several issues with "Table" and "Table V2" plugins.
   
   "**Table**":
   When server-side pagination is used, a "Search by" selector is displayed: it lists columns by their name rather than by their label, unlike the "Table V2" chart. I therefore made the necessary changes so that labels are used.
   <img width="903" height="292" alt="image" src="https://github.com/user-attachments/assets/ba1ad8ab-bd58-45a0-9477-3d89656750a3" />
   
   "**Table V2**":
   When server-side pagination is used, the "Page Size" selector does not behave as expected: the value configured for the chart is not applied correctly and the default value is applied (it is fine on initial display but is lost afterwards, for example when resizing the window).
   <img width="901" height="526" alt="image" src="https://github.com/user-attachments/assets/2b6d1683-9fa2-4035-a79a-78bc06f3b39b" />
   
   
   "**Table**" and "**Table V2**":
   Some strings could not be translated because the "t()" function intended for this purpose was not used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] UI fixes for table plugins [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36753:
URL: https://github.com/apache/superset/pull/36753#issuecomment-3672818457

   CodeAnt AI is reviewing your PR.
   
   ---
   
   ### Thanks for using CodeAnt! ๐ŸŽ‰
   
   We're free for open-source projects. if you're enjoying it, help us grow by sharing.
   
   [Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ยท
   [Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ยท
   [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] UI fixes for table plugins [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36753:
URL: https://github.com/apache/superset/pull/36753#issuecomment-3672827800

   CodeAnt AI finished reviewing your PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] UI fixes for table plugins [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36753:
URL: https://github.com/apache/superset/pull/36753#issuecomment-3672825584

   ## Nitpicks ๐Ÿ”
   
   <table>
   <tr><td>๐Ÿ”’&nbsp;<strong>No security issues identified</strong></td></tr>
   <tr><td>โšก&nbsp;<strong>Recommended areas for review</strong><br><br>
   
   - [ ] <a href='https://github.com/apache/superset/pull/36753/files#diff-fd855b910f6e482f1edd136d6c77cb64626f04fbfcef4c487a72aa0e75779ff0R524-R529'><strong>Page size fallback logic</strong></a><br>The page size passed to the Pagination component was simplified to `serverPaginationData?.pageSize ?? serverPageLength`. Previously there was logic using `hasServerPageLengthChanged` and falling back to a default (10). This change might reintroduce cases where the pageSize becomes undefined or does not respect the explore/editor patching behavior. Validate expected behavior when both values are undefined and when `hasServerPageLengthChanged` is true.<br>
   
   - [ ] <a href='https://github.com/apache/superset/pull/36753/files#diff-d987d4addee4ccb4cccae5bb4376bdf7915776d6e8631f9a777abfa98c08c9a0R788-R1260'><strong>Type assumptions / casting</strong></a><br>The code casts `columns` to a type that includes `columnLabel`. Ensure the returned column objects always include this field and the type definitions reflect it; otherwise the narrow cast may hide type issues. Consider extending the column return type or the ColumnWithLooseAccessor type instead of casting via `unknown`.<br>
   
   - [ ] <a href='https://github.com/apache/superset/pull/36753/files#diff-d987d4addee4ccb4cccae5bb4376bdf7915776d6e8631f9a777abfa98c08c9a0R794-R906'><strong>Column label selection</strong></a><br>The new `columnLabel` property is set from the local `label` variable, but the component computes a separate `displayLabel` that better represents what end-users see (especially for comparison columns). Verify that the value used for search dropdowns should be `displayLabel` rather than `label` so the "Search by" UI shows the intended human-facing strings.<br>
   
   - [ ] <a href='https://github.com/apache/superset/pull/36753/files#diff-bd919fa26ebe6f116bb11bdeb0fd42d9044597bf0e7066e6a2528ea8ba8c3f4eR121-R121'><strong>Translation staleness</strong></a><br>Calling `t()` in the function parameter default (and using React.memo via typedMemo) can prevent the component from picking up runtime locale changes because memoization may stop re-renders. Verify that translations update correctly when the app locale changes and consider computing translations inside the render with proper dependencies.<br>
   
   - [ ] <a href='https://github.com/apache/superset/pull/36753/files#diff-d987d4addee4ccb4cccae5bb4376bdf7915776d6e8631f9a777abfa98c08c9a0R1236-R1260'><strong>Derived state effect dependency</strong></a><br>`searchOptions` is derived from `columns`, but the effect that updates `searchOptions` lists `searchOptions` itself in the dependency array. That can cause unnecessary additional runs. Consider deriving options from `columns` only (useMemo) or update the effect dependency list to avoid redundant updates.<br>
   
   </td></tr>
   </table>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] UI fixes for table plugins [superset]

Posted by "nicob3y (via GitHub)" <gi...@apache.org>.
nicob3y closed pull request #36753: UI fixes for table plugins
URL: https://github.com/apache/superset/pull/36753


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] UI fixes for table plugins [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36753:
URL: https://github.com/apache/superset/pull/36753#issuecomment-3689838733

   CodeAnt AI is running Incremental review
   
   ---
   
   ### Thanks for using CodeAnt! ๐ŸŽ‰
   
   We're free for open-source projects. if you're enjoying it, help us grow by sharing.
   
   [Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ยท
   [Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ยท
   [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] UI fixes for table plugins [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36753:
URL: https://github.com/apache/superset/pull/36753#issuecomment-3672818664

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org