You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "Bruno Mahé (Created JIRA)" <ji...@apache.org> on 2011/10/26 21:53:33 UTC

[jira] [Created] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
------------------------------------------------------------------------------------------------------

                 Key: BIGTOP-175
                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
             Project: Bigtop
          Issue Type: Sub-task
          Components: Debian, General, RPM
    Affects Versions: 0.2.0
            Reporter: Bruno Mahé
            Assignee: Bruno Mahé
             Fix For: 0.2.0




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

Posted by "Bruno Mahé (Updated JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BIGTOP-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Mahé updated BIGTOP-175:
------------------------------

    Attachment: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
    
> All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-175
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Debian, General, RPM
>    Affects Versions: 0.2.0
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>             Fix For: 0.2.0
>
>         Attachments: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

Posted by "Bruno Mahé (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136409#comment-13136409 ] 

Bruno Mahé commented on BIGTOP-175:
-----------------------------------

wait, we are arguinig for nothing.
if JAVA_HOME is already defined, nothing will be auto-detected.
See:
> if [ -z "$JAVA_HOME" ]; then

                
> All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-175
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Debian, General, RPM
>    Affects Versions: 0.2.0
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>             Fix For: 0.2.0
>
>         Attachments: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d--2.patch, 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

Posted by "Bruno Mahé (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136391#comment-13136391 ] 

Bruno Mahé commented on BIGTOP-175:
-----------------------------------

from a very quick look, I haven't seen any easy way to set environment variable system wide for non login shells.

For the commands such as pig or hbase shell, the links cited above would work. And for the service scripts, the java home autodetection is already done after the sourcing of default files, which should cover your use case.
And also most projects make it possible to define JAVA_HOME in their <component>-config.sh.


                
> All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-175
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Debian, General, RPM
>    Affects Versions: 0.2.0
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>             Fix For: 0.2.0
>
>         Attachments: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d--2.patch, 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

Posted by "Roman Shaposhnik (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136349#comment-13136349 ] 

Roman Shaposhnik commented on BIGTOP-175:
-----------------------------------------

1. I would like to keep a pattern where we source anything in /etc/default/* AFTER the JAVA_HOME auto-detection. That way, a user can override any decisions made by our java detection code.
2. Why are we removing HBASE_PID_DIR ?

                
> All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-175
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Debian, General, RPM
>    Affects Versions: 0.2.0
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>             Fix For: 0.2.0
>
>         Attachments: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Issue Comment Edited] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

Posted by "Bruno Mahé (Issue Comment Edited JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136409#comment-13136409 ] 

Bruno Mahé edited comment on BIGTOP-175 at 10/26/11 9:26 PM:
-------------------------------------------------------------

wait, we are arguing for nothing.
if JAVA_HOME is already defined, nothing will be auto-detected.
See:
> if [ -z "$JAVA_HOME" ]; then

                
      was (Author: bmahe):
    wait, we are arguinig for nothing.
if JAVA_HOME is already defined, nothing will be auto-detected.
See:
> if [ -z "$JAVA_HOME" ]; then

                  
> All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-175
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Debian, General, RPM
>    Affects Versions: 0.2.0
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>             Fix For: 0.2.0
>
>         Attachments: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d--2.patch, 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Closed] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

Posted by "Bruno Mahé (Closed JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BIGTOP-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Mahé closed BIGTOP-175.
-----------------------------

    
> All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-175
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Debian, General, RPM
>    Affects Versions: 0.2.0
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>             Fix For: 0.2.0
>
>         Attachments: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d--2.patch, 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

Posted by "Roman Shaposhnik (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136363#comment-13136363 ] 

Roman Shaposhnik commented on BIGTOP-175:
-----------------------------------------

#1 I feel uncomfortable about users not being able to override the results of our JAVA_HOME detection for init.d scripts. Please suggest a different place for them to put JAVA_HOME=XXX 
                
> All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-175
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Debian, General, RPM
>    Affects Versions: 0.2.0
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>             Fix For: 0.2.0
>
>         Attachments: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d--2.patch, 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

Posted by "Bruno Mahé (Updated JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BIGTOP-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Mahé updated BIGTOP-175:
------------------------------

    Attachment: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d--2.patch

Here is a patch to apply on top of the previous one. It addresses 2.
                
> All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-175
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Debian, General, RPM
>    Affects Versions: 0.2.0
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>             Fix For: 0.2.0
>
>         Attachments: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d--2.patch, 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

Posted by "Roman Shaposhnik (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136367#comment-13136367 ] 

Roman Shaposhnik commented on BIGTOP-175:
-----------------------------------------

Looks good. Lets address #1 and it should be good to go.
                
> All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-175
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Debian, General, RPM
>    Affects Versions: 0.2.0
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>             Fix For: 0.2.0
>
>         Attachments: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d--2.patch, 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

Posted by "Bruno Mahé (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136355#comment-13136355 ] 

Bruno Mahé commented on BIGTOP-175:
-----------------------------------

1. Defining JAVA_HOME in /etc/default/<component> would be the wrong place to do it

2. I meant to source the hbase default file, but forgot to add it. Preparing another patch
                
> All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-175
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Debian, General, RPM
>    Affects Versions: 0.2.0
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>             Fix For: 0.2.0
>
>         Attachments: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

Posted by "Bruno Mahé (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136377#comment-13136377 ] 

Bruno Mahé commented on BIGTOP-175:
-----------------------------------

What I am referring to is only available in login shells. Let me look into it for non-login shells
                
> All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-175
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Debian, General, RPM
>    Affects Versions: 0.2.0
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>             Fix For: 0.2.0
>
>         Attachments: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d--2.patch, 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

Posted by "Roman Shaposhnik (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136410#comment-13136410 ] 

Roman Shaposhnik commented on BIGTOP-175:
-----------------------------------------

Indeed! Silly me -- goes to fetch a strong cup of Joe to start thinking straight ;-)

+1
                
> All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-175
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Debian, General, RPM
>    Affects Versions: 0.2.0
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>             Fix For: 0.2.0
>
>         Attachments: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d--2.patch, 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (BIGTOP-175) All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils

Posted by "Bruno Mahé (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136368#comment-13136368 ] 

Bruno Mahé commented on BIGTOP-175:
-----------------------------------

1. See https://help.ubuntu.com/community/EnvironmentVariables#Persistent_environment_variables and more precisely https://help.ubuntu.com/community/EnvironmentVariables#System-wide_environment_variables

                
> All of HBase wrapper scripts and init.d scripts need to start include find-java code from bigtop-utils
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-175
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-175
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Debian, General, RPM
>    Affects Versions: 0.2.0
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>             Fix For: 0.2.0
>
>         Attachments: 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d--2.patch, 0001-BIGTOP-175.-All-of-HBase-wrapper-scripts-and-init.d-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira