[jira] [Commented] (OFBIZ-12453) testInvoicePerShipmentSetFalse work with runtime configuration data

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517963#comment-17517963 ] 

ASF subversion and git services commented on OFBIZ-12453:
---------------------------------------------------------

Commit 4a5b0f829b0e834e70631a64e5b0c53cbe3d836e in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4a5b0f829b ]

Fixed: testInvoicePerShipmentSetFalse work with runtime configuration data (OFBIZ-12453)

UtilProperties::setPropertyValueInMemory was only based on files. Thinking by
analogy, as Pierre pushed SystemProperties with OFBIZ-6189, I thought that by
adding an UtilProperties::setPropertyValueInMemory based on
EntityUtilProperties::getProperties it would resolve the issue. But it did not.

Looking closer at the code, I wondered why UtilProperties::setPropertyValueInMemory
was used at all.

This fixes the issue by simply removing setPropertyValueInMemory and setting "Y"
or "N" when calling testInvoicePerShipment.

It though keeps the new UtilProperties::setPropertyValueInMemory variant


> testInvoicePerShipmentSetFalse work with runtime configuration data
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-12453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12453
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Trunk, Upcoming Branch
>            Reporter: Pierre Smits
>            Assignee: Jacques Le Roux
>            Priority: Major
>              Labels: integration-test, test-failure
>
> The testInvoicePerShipmentSetFalse fails when the following is loaded into the SystemProperty table and the test is executed.
> {code:java}
> <SystemProperty systemResourceId="accounting" systemPropertyId="create.invoice.per.shipment" 
> systemPropertyValue="Y"
> description="create invoice per shipment. Options: = Y (Invoice per shipment), N (Invoice per order)"/> {code}
> See https://github.com/apache/ofbiz-framework/blob/trunk/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/InvoicePerShipmentTests.groovy



--
This message was sent by Atlassian Jira
(v8.20.1#820001)